Skip to content

ZEPPELIN-360 Remove "Copyright 2014, NFLabs inc." from LICENSE #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Leemoonsoo wants to merge 2 commits into from
Closed

ZEPPELIN-360 Remove "Copyright 2014, NFLabs inc." from LICENSE #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb75e86
ZEPPELIN-360 Remove "Copyright 2014, NFLabs inc." from LICENSE
Leemoonsoo Oct 25, 2015
cfb814b
Remove "Copyright (c) 2010-2015 NFLabs Inc." from NOTICE
Leemoonsoo Oct 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2014, NFLabs inc.
Copyright [yyyy] [name of copyright owner]
Copy link
Member

@jongyoul jongyoul Oct 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leemoonsoo Is it enough? Will it be filled automatically?

Copy link
Member Author

@Leemoonsoo Leemoonsoo Oct 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked some TLPs to see how they do. And looks like it's enough. I'm also curious if it is enough (and why).

Copy link
Member

@jongyoul jongyoul Oct 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm also curious :)

Copy link
Member Author

@Leemoonsoo Leemoonsoo Oct 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can one of our mentors clarify it?

Copy link
Member

@felixcheung felixcheung Oct 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is talking about "How to apply the Apache License to your work."

  APPENDIX: How to apply the Apache License to your work.        To apply the Apache License to your work, attach the following       boilerplate notice, with the fields enclosed by brackets "[]"       replaced with your own identifying information. (Don't include       the brackets!)  The text should be enclosed in the appropriate       comment syntax for the file format. We also recommend that a       file or class name and description of purpose be included on the       same "printed page" as the copyright notice for easier          identification within third-party archives. ```

So I think [yyyy] [name of copyright owner] is indeed correct.

Copy link
Member Author

@Leemoonsoo Leemoonsoo Oct 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm merging it.


Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
1 change: 0 additions & 1 deletion NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ The Apache Software Foundation (http://www.apache.org/).


Portions of this software were developed at NFLabs, Inc. (http://www.nflabs.com)
Copyright (c) 2010-2015 NFLabs Inc.



Expand Down