Skip to content

Conversation

@vthinkxie
Copy link
Contributor

@vthinkxie vthinkxie commented Jan 16, 2020

What is this PR for?

Support scroll to the paragraph specified by the url param

What type of PR is it?

[Feature]

Todos

  • - Task

What is the Jira issue?

[ZEPPELIN-4552]

How should this be tested?

https://travis-ci.org/vthinkxie/zeppelin/builds/637914933

Screenshots (if appropriate)

截屏2020-01-19下午4 01 47

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjffdu
Copy link
Contributor

zjffdu commented Jan 19, 2020

@vthinkxie Could you update the PR description ? And a screenshot would be helpful

@vthinkxie
Copy link
Contributor Author

updated

@zjffdu
Copy link
Contributor

zjffdu commented Jan 19, 2020

PR title is not completed.

image

@vthinkxie vthinkxie changed the title [ZEPPELIN-4552] Support scroll to the paragraph specified by the url … [ZEPPELIN-4552] Support scroll to the paragraph specified by the url param Jan 19, 2020
@vthinkxie
Copy link
Contributor Author

fixed

@zjffdu
Copy link
Contributor

zjffdu commented Jan 19, 2020

@vthinkxie
Part of title is still in PR description

image

@vthinkxie
Copy link
Contributor Author

I think it is an auto cut from GitHub 50/72 formatting commit message, fixed it now.

@asfgit asfgit closed this in 6a122cc Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants