Skip to content

[ZEPPELIN-4551]. upgrade-note.sh Plugin GitNotebookRepo doesn't exist #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zjffdu wants to merge 1 commit into from
Closed

[ZEPPELIN-4551]. upgrade-note.sh Plugin GitNotebookRepo doesn't exist #3598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions zeppelin-zengine/src/main/java/org/apache/zeppelin/plugin/PluginManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,17 +100,14 @@ private String getOldNotebookRepoClassName(String notebookRepoClassName) {
*/
public OldNotebookRepo loadOldNotebookRepo(String notebookRepoClassName) throws IOException {
LOGGER.info("Loading OldNotebookRepo Plugin: " + notebookRepoClassName);
// load plugin from classpath directly when it is test.
// otherwise load it from plugin folder
String isTest = System.getenv("IS_ZEPPELIN_TEST");
if (isTest != null && isTest.equals("true")) {
try {
OldNotebookRepo notebookRepo = (OldNotebookRepo)
(Class.forName(notebookRepoClassName).newInstance());
return notebookRepo;
} catch (InstantiationException | IllegalAccessException | ClassNotFoundException e) {
LOGGER.warn("Fail to instantiate notebookrepo from classpath directly:" + notebookRepoClassName);
}
// load plugin from classpath directly first for these builtin NotebookRepo (such as VFSNoteBookRepo
// and GitNotebookRepo). If fails, then try to load it from plugin folder
try {
OldNotebookRepo notebookRepo = (OldNotebookRepo)
(Class.forName(notebookRepoClassName).newInstance());
return notebookRepo;
} catch (InstantiationException | IllegalAccessException | ClassNotFoundException e) {
LOGGER.warn("Fail to instantiate notebookrepo from classpath directly:" + notebookRepoClassName);
}

String simpleClassName = notebookRepoClassName.substring(notebookRepoClassName.lastIndexOf(".") + 1);
Expand Down