Skip to content

Conversation

@zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Jan 16, 2020

What is this PR for?

Default interpreter is missing in shell interpreter's interpreter-setting.json, this cause the frontend unable to get right editor setting when using %sh.

What type of PR is it?

[Bug Fix ]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • Test is manually

Screenshots (if appropriate)

Before

image

After
image

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjffdu
Copy link
Contributor Author

zjffdu commented Jan 18, 2020

Thanks for review @alexott

@asfgit asfgit closed this in 72635f3 Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants