[ZEPPELIN-4540] Convert code editor font size units #3588
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM, thanks @hsuanxyz |
asfgit
pushed a commit
that referenced
this pull request
Jan 10, 2020
### What is this PR for? Convert code editor font size units (from pt to px). ### What type of PR is it? [Bug Fix] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-4540 ### How should this be tested? N/A ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Hsuan Lee <[email protected]> Closes #3588 from hsuanxyz/fix/code-editor-font-size and squashes the following commits: 3778a12 [Hsuan Lee] fix: convert code editor font size units
asfgit
pushed a commit
that referenced
this pull request
Jan 12, 2020
### What is this PR for? Convert code editor font size units (from pt to px). ### What type of PR is it? [Bug Fix] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-4540 ### How should this be tested? N/A ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Hsuan Lee <[email protected]> Closes #3588 from hsuanxyz/fix/code-editor-font-size and squashes the following commits: 3778a12 [Hsuan Lee] fix: convert code editor font size units
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Convert code editor font size units (from pt to px).
What type of PR is it?
[Bug Fix]
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4540
How should this be tested?
N/A
Screenshots (if appropriate)
N/A
Questions: