[ZEPPELIN-4450] Provide Angular.js Template Migration Tool #3528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Nov 27, 2019
### What is this PR for? We have implemented the frontend API of Angular.js using the latest Angular. But the templates some [differences](https://angular.io/guide/ajs-quick-reference) between Angular.js and Angular. So to help users migrate templates, we provide a migration tool that will be integrated into the Zeppelin web. This is its [DEMO](https://ng1-updater.hsuan.xyz/) it can quickly fix these differences. We plan to do the following work: 1. Add a new type `%ng` (official abbreviation) to distinguish between Angular.js and Angular templates. 2. When the user runs a paragraph with the `%angular` type, the upgrade dialog will be open. 3. Upgrade the template in the dialog and click the `Update and Copy` button. 4. Automatically create a paragraph of type `%ng` template in below ### What type of PR is it? [Feature] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-4321 https://issues.apache.org/jira/browse/ZEPPELIN-4450 ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NO Author: Hsuan Lee <[email protected]> Closes #3528 from hsuanxyz/angularjs-template-compatible and squashes the following commits: 3474f81 [Hsuan Lee] fix: fix editor focus d639a2b [Hsuan Lee] fix: fix focus bar 38d0c46 [Hsuan Lee] chore: update code editor actions 1a28a7a [Hsuan Lee] feat: provide Angular.js template migration tool
asfgit
pushed a commit
that referenced
this pull request
Dec 30, 2019
### What is this PR for? We have implemented the frontend API of Angular.js using the latest Angular. But the templates some [differences](https://angular.io/guide/ajs-quick-reference) between Angular.js and Angular. So to help users migrate templates, we provide a migration tool that will be integrated into the Zeppelin web. This is its [DEMO](https://ng1-updater.hsuan.xyz/) it can quickly fix these differences. We plan to do the following work: 1. Add a new type `%ng` (official abbreviation) to distinguish between Angular.js and Angular templates. 2. When the user runs a paragraph with the `%angular` type, the upgrade dialog will be open. 3. Upgrade the template in the dialog and click the `Update and Copy` button. 4. Automatically create a paragraph of type `%ng` template in below ### What type of PR is it? [Feature] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-4321 https://issues.apache.org/jira/browse/ZEPPELIN-4450 ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NO Author: Hsuan Lee <[email protected]> Closes #3528 from hsuanxyz/angularjs-template-compatible and squashes the following commits: 3474f81 [Hsuan Lee] fix: fix editor focus d639a2b [Hsuan Lee] fix: fix focus bar 38d0c46 [Hsuan Lee] chore: update code editor actions 1a28a7a [Hsuan Lee] feat: provide Angular.js template migration tool
asfgit
pushed a commit
that referenced
this pull request
Jan 12, 2020
### What is this PR for? We have implemented the frontend API of Angular.js using the latest Angular. But the templates some [differences](https://angular.io/guide/ajs-quick-reference) between Angular.js and Angular. So to help users migrate templates, we provide a migration tool that will be integrated into the Zeppelin web. This is its [DEMO](https://ng1-updater.hsuan.xyz/) it can quickly fix these differences. We plan to do the following work: 1. Add a new type `%ng` (official abbreviation) to distinguish between Angular.js and Angular templates. 2. When the user runs a paragraph with the `%angular` type, the upgrade dialog will be open. 3. Upgrade the template in the dialog and click the `Update and Copy` button. 4. Automatically create a paragraph of type `%ng` template in below ### What type of PR is it? [Feature] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-4321 https://issues.apache.org/jira/browse/ZEPPELIN-4450 ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NO Author: Hsuan Lee <[email protected]> Closes #3528 from hsuanxyz/angularjs-template-compatible and squashes the following commits: 3474f81 [Hsuan Lee] fix: fix editor focus d639a2b [Hsuan Lee] fix: fix focus bar 38d0c46 [Hsuan Lee] chore: update code editor actions 1a28a7a [Hsuan Lee] feat: provide Angular.js template migration tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
We have implemented the frontend API of Angular.js using the latest Angular. But the templates some differences between Angular.js and Angular.
So to help users migrate templates, we provide a migration tool that will be integrated into the Zeppelin web. This is its DEMO it can quickly fix these differences.
We plan to do the following work:
%ng(official abbreviation) to distinguish between Angular.js and Angular templates.%angulartype, the upgrade dialog will be open.Update and Copybutton.%ngtemplate in belowWhat type of PR is it?
[Feature]
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4321
https://issues.apache.org/jira/browse/ZEPPELIN-4450
How should this be tested?
Screenshots (if appropriate)
Questions: