[ZEPPELIN-4226] Fix "View in Spark web UI" in kubernetes mode #3451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjffdu
reviewed
Sep 19, 2019
| val sparkShims = SparkShims.getInstance(sc.version, properties) | ||
| sparkShims.setupSparkListener(sc.master, sparkUrl, InterpreterContext.get) | ||
| var webUiUrl = properties.getProperty("zeppelin.spark.uiWebUrl"); | ||
| if (webUiUrl == null || webUiUrl.trim().length() == 0) { |
Contributor
There was a problem hiding this comment.
Maybe use StringUtils.isBlank() which is more clean
felixcheung
approved these changes
Sep 23, 2019
Contributor
|
LGTM |
Member
Author
|
Merge to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
When Zeppelin is running in Kubernetes, "View in Spark web UI" gives internal address, instead of address defined in SERVICE_DOMAIN.
I think this problem is side effect of #3375 and this PR includes fix and updated unittest.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4226
How should this be tested?
Run Zeppelin on kubernetes, and run spark job, click "View in Spark web UI" button.
Questions: