Skip to content

[ZEPPELIN-3062] Removes ctrl+s default behavior from notebook #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tessbianchi wants to merge 1 commit into from
Closed

[ZEPPELIN-3062] Removes ctrl+s default behavior from notebook #2677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions zeppelin-web/src/app/notebook/notebook.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,23 @@ function NotebookCtrl ($scope, $route, $routeParams, $location, $rootScope,
// register mouseevent handler for focus paragraph
document.addEventListener('click', $scope.focusParagraphOnClick)

$scope.keyboardShortcut = function (keyEvent) {
let keyboardShortcut = function (keyEvent) {
// handle keyevent
if (!$scope.viewOnly && !$scope.revisionView) {
$scope.$broadcast('keyEvent', keyEvent)
}
}

$scope.keydownEvent = function (keyEvent) {
if ((keyEvent.ctrlKey || keyEvent.metaKey) && String.fromCharCode(keyEvent.which).toLowerCase() === 's') {
Copy link
Member

@felixcheung felixcheung Nov 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this metaKey is Alt in Windows though, would this disable that?

Copy link
Contributor Author

@tessbianchi tessbianchi Nov 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does alt + s have important behavior in windows / ubuntu?

keyEvent.preventDefault()
}

keyboardShortcut(keyEvent)
}

// register mouseevent handler for focus paragraph
document.addEventListener('keydown', $scope.keyboardShortcut)
document.addEventListener('keydown', $scope.keydownEvent)

$scope.paragraphOnDoubleClick = function (paragraphId) {
$scope.$broadcast('doubleClickParagraph', paragraphId)
Expand Down