Skip to content

Conversation

@zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Oct 13, 2017

What is this PR for?

Trivial fix for matplotlib fail in IPythonInterpreter. Besides that, I also make some minor changes on zeppelin code to improve logging.

What type of PR is it?

[Bug Fix]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

UT is added.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I see a bunch of ipython failure in other PR, is this the cause?

@zjffdu zjffdu force-pushed the ZEPPELIN-2990 branch 2 times, most recently from 1069385 to d6b2722 Compare October 14, 2017 05:43
@zjffdu
Copy link
Contributor Author

zjffdu commented Oct 16, 2017

@felixcheung Right, this PR is trying to fix these flaky test.

@zjffdu
Copy link
Contributor Author

zjffdu commented Oct 16, 2017

I will merge it soon as it fix the flaky travis build as well.

@asfgit asfgit closed this in 152538b Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants