Skip to content

[Minor] Remove hardcoded key in zeppelinhub. #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yanboliang wants to merge 1 commit into from
Closed

[Minor] Remove hardcoded key in zeppelinhub. #2621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .../src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/security/Authentication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public class Authentication implements Runnable {
// Cipher is an AES in CBC mode
private static final String CIPHER_ALGORITHM = "AES";
private static final String CIPHER_MODE = "AES/CBC/PKCS5PADDING";
private static final String KEY = "AbtEr99DxsWWbJkP";
private static final int ivSize = 16;

private static final String ZEPPELIN_CONF_ANONYMOUS_ALLOWED = "zeppelin.anonymous.allowed";
Expand Down Expand Up @@ -198,7 +197,7 @@ private Map<String, String> login(String authKey, String endpoint) {
private Key generateKey() {
try {
KeyGenerator kgen = KeyGenerator.getInstance(CIPHER_ALGORITHM);
kgen.init(128, new SecureRandom(toBytes(KEY)));
kgen.init(128, new SecureRandom());
SecretKey secretKey = kgen.generateKey();
byte[] enCodeFormat = secretKey.getEncoded();
return new SecretKeySpec(enCodeFormat, CIPHER_ALGORITHM);
Expand Down