ZEPPELIN-2985: correct grammar in keyboard tooltip #2617
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixcheung
reviewed
Oct 11, 2017
Member
felixcheung
left a comment
felixcheung
left a comment
There was a problem hiding this comment.
ok, could you please check the rest of notebook-actionBar.html to see there is anything else to change?
Member
|
I tried to search other typo but couldn't find (for viable text, not for css class things). LGTM.
|
Member
|
Thanks @gef756 for the fix. LGTM |
felixcheung
approved these changes
Oct 13, 2017
Contributor
Author
|
Cool! Do you guys need anything else from my end? |
Member
|
Thanks @gef756 for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The tooltip for "List of shortcut" should read "List of shortcuts" (plural).
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
How should this be tested?
tooltip. (Shows up then hides based on cursor position)
Screenshots (if appropriate)
Questions: