-
Notifications
You must be signed in to change notification settings - Fork 2.8k
ZEPPELIN-1897 REST API - Update paragraph text/title via API #2604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
felixcheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you update the PR title to say "update paragraph title"
docs/usage/rest_api/notebook.md
Outdated
| "status": "OK", | ||
| "message": "", | ||
| "body": { | ||
| "title": "Hellow world", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the text of the paragraph? do we need to return it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixcheung Good point. Don't see the need at this point so I've removed the response's body. Docs updated.
|
@felixcheung I've updated the the PR title to be more clear |
felixcheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this LGTM. since this is updating an existing paragraph there might be other implications that I'm not aware of, I'd like others to review as well
| post.releaseConnection(); | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove extra newlines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
also, there are some test failures, could you take a look? |
|
@felixcheung The build seems to be very flaky. |
|
ok, agreed that seems unrelated. btw, it would be easier for reviewer to track changes if you do not force push any comment on this PR? I'd wait for a couple of days. |
What is this PR for?
Support updating paragraph text/title via REST API
https://issues.apache.org/jira/browse/ZEPPELIN-1897
What type of PR is it?
Improvement
Todos
What is the Jira issue?
[ZEPPELIN-1897]
How should this be tested?
curl -X PUT http://localhost:8080/api/notebook/NOTE_ID/paragraph/PARAGRAPH_ID -d '{"text": "some updated text"}'Screenshots (if appropriate)
Questions: