ZEPPELIN-2953 Allow custom http header for livy interpreter #2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bikassaha
reviewed
Sep 26, 2017
| </tr> | ||
| <tr> | ||
| <td>zeppelin.livy.http.headers</td> | ||
| <td>key_1: value_1; key_2: value_2</td> |
There was a problem hiding this comment.
Are ; and : valid separators that would not be present in any header itself?
Contributor
Author
There was a problem hiding this comment.
felixcheung
reviewed
Sep 28, 2017
Member
felixcheung
left a comment
felixcheung
left a comment
There was a problem hiding this comment.
is there a concrete example of what this could be useful for?
Contributor
Author
|
Custom http headers is needed when integrating knox with livy interpreter. |
felixcheung
approved these changes
Sep 28, 2017
| String[] headers = property.getProperty("zeppelin.livy.http.headers").split(";"); | ||
| for (String header : headers) { | ||
| String[] splits = header.split(":"); | ||
| customHeaders.put(splits[0].trim(), splits[1].trim()); |
Member
There was a problem hiding this comment.
handle the case when splits[1] is empty?
Member
There was a problem hiding this comment.
per rfc, looks like : is required but field value is not.
we should probably error out if : is missing but handle empty value
zjffdu
force-pushed
the
ZEPPELIN-2953
branch
2 times, most recently
from
301f8bb to
a615f00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR is trying to allow user to add custom http headers when calling livy rest api. User just need to specify
zeppelin.livy.http.headersin livy interpreter settingWhat type of PR is it?
[Feature]
Todos
What is the Jira issue?
How should this be tested?
Outline the steps to test the PR here.
Screenshots (if appropriate)
Questions: