Skip to content

Conversation

@1ambda
Copy link
Member

@1ambda 1ambda commented Sep 11, 2017

What is this PR for?

Fixed broken javascript source map. The coverage loader should be used only for test env.

that's really annoying because we can't set breakpoint and even can't see the original source code.

What type of PR is it?

[Bug Fix]

What is the Jira issue?

ZEPPELIN-2924

How should this be tested?

  1. run the webapp as dev mode: localhost:9000
  2. open the developer console and click any log message
  3. check whether source is minified or not.
  4. execute yarn run test in the terminal to check that coverage feature works well.

Screenshots (if appropriate)

Before

image

image

After

image

image

Questions:

  • Does the licenses files need update? - NO
  • Is there breaking changes for older versions? - NO
  • Does this needs documentation? - NO

@1ambda 1ambda closed this Sep 11, 2017
@1ambda 1ambda reopened this Sep 11, 2017
@1ambda 1ambda closed this Sep 11, 2017
@1ambda 1ambda reopened this Sep 11, 2017
@jongyoul
Copy link
Member

LGTM

@1ambda
Copy link
Member Author

1ambda commented Oct 2, 2017

thanks for review. merge if no more discussion

@asfgit asfgit closed this in fc9d542 Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants