[ZEPPELIN-2841] fix a problem in shell interpreter . Working directory '.' can not be found in docker environment #2521
Conversation
merge apache/zeppelin
vistep
changed the title
|
Jenkins said that "Can't find build for commit e8cbdd1 from vistep". |
felixcheung
left a comment
felixcheung
left a comment
There was a problem hiding this comment.
please see
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
Looks like travis-ci is not configured for your fork.
Please setup by swich on 'zeppelin' repository at https://travis-ci.org/profile and travis-ci.
And then make sure 'Build branch updates' option is enabled in the settings https://travis-ci.org/SachinJanani/zeppelin/settings.
To trigger CI after setup, you will need ammend your last commit with
git commit --amend
git push your-remote HEAD --force
See http://zeppelin.apache.org/contribution/contributions.html#continuous-integration.
| contextInterpreter.out, contextInterpreter.out)); | ||
| executor.setWatchdog(new ExecuteWatchdog(Long.valueOf(getProperty(TIMEOUT_PROPERTY)))); | ||
| executors.put(contextInterpreter.getParagraphId(), executor); | ||
| executor.setWorkingDirectory(new File(System.getenv("HOME"))); |
There was a problem hiding this comment.
this won't work in windows though (well)
There was a problem hiding this comment.
Thanks so much, I will try to figure it out.
|
I replaced System.getenv("HOME") with System.getProperty("user.home") . |
|
build sometimes fail because of network connection problem of flaky tests. |
…ng directory '.' can not be found while zeppelin was running in docker enviroment.
|
I tried again and it passed. |
|
LGTM and merge to master and branch-0.7 if no further comment. |
…y '.' can not be found in docker environment ### What is this PR for? shell interpreter complained that working directory '.' can not be found in docker environment. I add a line of code to set current working directory to USER`s home, and it works. ### What type of PR is it? Bug Fix ### Todos * tests ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2841 ### How should this be tested? run shell interpreter`s test units ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Shu Jiaming <[email protected]> Author: 束佳明 <[email protected]> Closes #2521 from vistep/master and squashes the following commits: 34a0049 [Shu Jiaming] ZEPPELIN-2841 fix a bug where shell interpreter complained that working directory '.' can not be found while zeppelin was running in docker enviroment. d02104a [束佳明] Merge pull request #1 from apache/master (cherry picked from commit 71d1305) Signed-off-by: Lee moon soo <[email protected]>
|
This implementation has a harmful side effect that can break existing notebooks. The problem with this fix is that it changes the meaning of all relative path-names used in any shell commands. For example, after this fix, the command One immediate change that is suggested is to change the fix to make it apply only to the narrow situation it is needed in (a Docker environment). |
|
Can we use a try-catch block to test if we need to set working directory when zeppelin opens a shell interpreter? |
|
I have not looked at the code in detail, so will refrain from making suggestions about the code :-) |
|
@Leemoonsoo How about the idea above? |
|
@sanjaydasgupta @vistep have create JIRA for the same https://issues.apache.org/jira/browse/ZEPPELIN-2903. |
5 participants
What is this PR for?
shell interpreter complained that working directory '.' can not be found in docker environment.
I add a line of code to set current working directory to USER`s home, and it works.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2841
How should this be tested?
run shell interpreter`s test units
Screenshots (if appropriate)
Questions:
No
No
No