[ZEPPELIN-2492] Use single Dockerfile for each tag (branch-0.7) #2388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Leemoonsoo This is created for branch-0.7. For master, #2318 was already merged. Could you help to review this? |
Member
|
I'll merge it |
asfgit
pushed a commit
that referenced
this pull request
Jun 4, 2017
### What is this PR for? **This PR is created for branch-0.7** **#2318 was already merged into master** Use single `Dockerfile` for each release since [apache infra uses tag pushes](https://issues.apache.org/jira/browse/INFRA-12781) to build an image. - https://issues.apache.org/jira/browse/INFRA-12781 After release process finishes, dockerhub will build using the pushed tag. ### What type of PR is it? [Improvement] ### What is the Jira issue? [ZEPPELIN-2492](https://issues.apache.org/jira/browse/ZEPPELIN-2492) ### How should this be tested? 1. `./dev/change_zeppelin_version.sh 0.8.0-SNAPSHOT 0.7.1` 2. Check that version is properly set: `vi scrtips/docker/zeppelin/bin/Dockerfile` 3. Build docker image `cd scripts/docker/zeppelin/bin; docker build -t zeppelin:0.7.1 ./` 4. Run the image: `docker run -p 8080:8080 --rm --name zeppelin zeppelin:0.7.1` ### Screenshots (if appropriate) NONE ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <[email protected]> Closes #2388 from 1ambda/ZEPPELIN-2492/use-single-dockerfile-for-each-tag-branch07 and squashes the following commits: 64b3fe0 [1ambda] docs: Update docker.md 1471096 [1ambda] feat: Add dockerfile for tag push
Member
|
Can you close it by yourself? |
Member
Author
|
Thanks @jongyoul. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR is created for branch-0.7
#2318 was already merged into master
Use single
Dockerfilefor each release since apache infra uses tag pushes to build an image.After release process finishes, dockerhub will build using the pushed tag.
What type of PR is it?
[Improvement]
What is the Jira issue?
ZEPPELIN-2492
How should this be tested?
./dev/change_zeppelin_version.sh 0.8.0-SNAPSHOT 0.7.1vi scrtips/docker/zeppelin/bin/Dockerfilecd scripts/docker/zeppelin/bin; docker build -t zeppelin:0.7.1 ./docker run -p 8080:8080 --rm --name zeppelin zeppelin:0.7.1Screenshots (if appropriate)
NONE
Questions: