[ZEPPELIN-2467] Restore travis second job functionality #2342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
Author
|
Merge to master if no further discussions |
asfgit
pushed a commit
that referenced
this pull request
May 18, 2017
…RestApiTest fails on travis ### What is this PR for? shiro returns multiple JSESSIONID on login request in integration test. ```bash moon$ curl -v -XPOST -H "Origin: http://localhost:8080/api" -H "Host: localhost:8080" --data "userName=admin&password=password1" 'http://localhost:8080/api/login' * Trying ::1... * Connected to localhost (::1) port 8080 (#0) > POST /api/login HTTP/1.1 > Host: localhost:8080 > User-Agent: curl/7.43.0 > Accept: */* > Origin: http://localhost:8080/api > Content-Length: 33 > Content-Type: application/x-www-form-urlencoded > * upload completely sent off: 33 out of 33 bytes < HTTP/1.1 200 OK < Date: Mon, 15 May 2017 14:24:10 GMT < Access-Control-Allow-Origin: http://localhost:8080/api < Access-Control-Allow-Credentials: true < Access-Control-Allow-Headers: authorization,Content-Type < Access-Control-Allow-Methods: POST, GET, OPTIONS, PUT, HEAD, DELETE < Date: Monday, May 15, 2017 7:24:10 AM PDT < Set-Cookie: rememberMe=deleteMe; Path=/; Max-Age=0; Expires=Sun, 14-May-2017 14:24:10 GMT < Set-Cookie: JSESSIONID=2c0062db-99f0-438c-a5f6-6fdffa4eb7ae; Path=/; HttpOnly < Set-Cookie: JSESSIONID=deleteMe; Path=/; Max-Age=0; Expires=Sun, 14-May-2017 14:24:10 GMT < Set-Cookie: JSESSIONID=6bb25285-6cb0-47ea-8bb6-e268110a6034; Path=/; HttpOnly < Set-Cookie: rememberMe=deleteMe; Path=/; Max-Age=0; Expires=Sun, 14-May-2017 14:24:10 GMT < Content-Type: application/json < Date: Mon, 15 May 2017 14:24:10 GMT < Content-Length: 123 < Server: Jetty(9.2.15.v20160210) < * Connection #0 to host localhost left intact ``` Later one is valid JSESSIONID. This PR changes test code to use last JSESSIONID. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2545 https://issues.apache.org/jira/browse/ZEPPELIN-2546 ### How should this be tested? After #2342 is merged, this PR will be rebased. Then CI should be green. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes #2344 from Leemoonsoo/ZEPPELIN-2545 and squashes the following commits: ed43ce9 [Lee moon soo] enable SecurityRestApiTest, NotebookSecurityRestApiTest 70915a2 [Lee moon soo] use last JSESSIONID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
issue ZEPPELIN-2467 has resolved by #2300. However 8194a5e reverts #2300.
This PR apply #2300 again with two more test exclusion:
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2467
How should this be tested?
CI becomes green
Questions: