[ZEPPELIN-2484] Fix NullPointerException in check for empty last paragraph #2310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoyantony
changed the title
Member
|
LGTM and merge to master if no further comments. |
benoyantony
changed the title
michelemilesi
pushed a commit
to icteam-spa/zeppelin
that referenced
this pull request
May 11, 2017
…graph ### What is this PR for? Prevent NullPointerException during check to determine whether a new paragraph needs to added. The fix is to switch order of null check and trim operation so that null check is performed before trim() ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2484 ### How should this be tested? This can be tested with a hive interpreter Create a note and add a paragraph with some query in it. Run all paragraphs. A new paragraph is automatically added. Run all paragraphs again. A NullPointerException is logged in the logs. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Benoy Antony <[email protected]> Closes apache#2310 from benoyantony/ZEPPELIN-2484 and squashes the following commits: 1cc2f8b [Benoy Antony] ZEPPELIN-2484 do a Null check before calling trim on paragraph's text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Prevent NullPointerException during check to determine whether a new paragraph needs to added.
The fix is to switch order of null check and trim operation so that null check is performed before trim()
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2484
How should this be tested?
This can be tested with a hive interpreter
Create a note and add a paragraph with some query in it.
Run all paragraphs.
A new paragraph is automatically added.
Run all paragraphs again. A NullPointerException is logged in the logs.
Screenshots (if appropriate)
Questions: