[ZEPPELIN-2382] Fixed windows compatibility of interpreter binding. #2305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script previously modified the CLASSPATH variable. This may lead to an undesired side effect, where the zeppelin server classpath is exported to the zeppelin interpreter classpath, see JIRA issue ZEPPELIN-2375 for details. Instead of modifying classpath we now work the other way around and set ZEPPELIN_CLASSPATH or ZEPPELIN_INT_CLASSPATH to include CLASSPATH and then use ZEPPELIN_CLASSPATH or ZEPPELIN_INT_CLASSPATH in the corresponding exec (runner), respectively. See also https://issues.apache.org/jira/browse/ZEPPELIN-2375
On Windows system the Files.setPosixFilePermissions will (currently) fail. For the case that the operation is not supported we just continue (keep finger crossed) (on windows the file apparently has the right permissions).
Contributor
Author
|
The reporter of https://issues.apache.org/jira/browse/ZEPPELIN-2382 has checked the corresponding build. This pr fixes [ZEPPELIN-2382]. |
|
I confirm this works. |
Contributor
Author
|
The tests are not failing. See Travis: (there is some issue with Jenkins/Travis which make tests sometimes fails). |
Contributor
Author
|
(Sorry for the stupid question: what is the workaround if Jenkins fails but Travis succeeds on a re-run? Close and Re-Open? Could anyone just restart Jenkins?). |
Member
|
@cfries yes, close and re-open will trigger Jenkins and get latest travis job result. |
felixcheung
approved these changes
May 4, 2017
Member
|
LGTM and merge to master and branch-0.7 if no further comments |
asfgit
pushed a commit
that referenced
this pull request
May 6, 2017
### What is this PR for? Fixing ZEPPELIN-2382: A fresh install of Zeppelin 0.7.1 failed to start on a Windows due to the use of [getPosixFilePermissions](https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#getPosixFilePermissions(java.nio.file.Path,%20java.nio.file.LinkOption...)) This method fails on Windows with an UnsupportedOperationException - however, recovering (that is ignoring the exception) appears to have no negative effects. (For a discussion on this related to a different project see, e.g., GoogleCloudPlatform/cloud-code-intellij#937 ) ### What type of PR is it? [Bug Fix] ### Todos * [x] - Have the binary distribution checked by the reporter of [ZEPPELIN-2382] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2382 ### How should this be tested? Check if clean distribution runs on Windows. Important: Ensure that HADOOP_HOME points to a folder containing bin/winutils.exe since this pull request does not include a fix for https://issues.apache.org/jira/browse/ZEPPELIN-2438 (which is part of a separate pull request). ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Christian Fries <[email protected]> Closes #2305 from cfries/windows-compatiblity-interpreter-binding and squashes the following commits: e3b5738 [Christian Fries] Added graceful exception handling if posix permission is not available 096fed6 [Christian Fries] Merge branch 'master' into apache/master 3635ed8 [Christian Fries] [ZEPPELIN-2375]: Avoid modification of CLASSPATH variable. (cherry picked from commit fb80bf7) Signed-off-by: Lee moon soo <[email protected]>
michelemilesi
pushed a commit
to icteam-spa/zeppelin
that referenced
this pull request
May 11, 2017
### What is this PR for? Fixing ZEPPELIN-2382: A fresh install of Zeppelin 0.7.1 failed to start on a Windows due to the use of [getPosixFilePermissions](https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#getPosixFilePermissions(java.nio.file.Path,%20java.nio.file.LinkOption...)) This method fails on Windows with an UnsupportedOperationException - however, recovering (that is ignoring the exception) appears to have no negative effects. (For a discussion on this related to a different project see, e.g., GoogleCloudPlatform/cloud-code-intellij#937 ) ### What type of PR is it? [Bug Fix] ### Todos * [x] - Have the binary distribution checked by the reporter of [ZEPPELIN-2382] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2382 ### How should this be tested? Check if clean distribution runs on Windows. Important: Ensure that HADOOP_HOME points to a folder containing bin/winutils.exe since this pull request does not include a fix for https://issues.apache.org/jira/browse/ZEPPELIN-2438 (which is part of a separate pull request). ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Christian Fries <[email protected]> Closes apache#2305 from cfries/windows-compatiblity-interpreter-binding and squashes the following commits: e3b5738 [Christian Fries] Added graceful exception handling if posix permission is not available 096fed6 [Christian Fries] Merge branch 'master' into apache/master 3635ed8 [Christian Fries] [ZEPPELIN-2375]: Avoid modification of CLASSPATH variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fixing ZEPPELIN-2382:
A fresh install of Zeppelin 0.7.1 failed to start on a Windows due to the use of getPosixFilePermissions
This method fails on Windows with an UnsupportedOperationException - however, recovering (that is ignoring the exception) appears to have no negative effects. (For a discussion on this related to a different project see, e.g., GoogleCloudPlatform/cloud-code-intellij#937 )
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2382
How should this be tested?
Check if clean distribution runs on Windows. Important: Ensure that HADOOP_HOME points to a folder containing bin/winutils.exe since this pull request does not include a fix for https://issues.apache.org/jira/browse/ZEPPELIN-2438 (which is part of a separate pull request).
Screenshots (if appropriate)
N/A
Questions:
Does the licenses files need update?
No
Is there breaking changes for older versions?
No
Does this needs documentation?
No