[hotfix] Improve Session #2302 fix #2304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Tagar please help review this PR. |
Contributor
|
Thanks for prompt response @prabhjyotsingh |
Contributor
Author
|
Thank you for the validation @Tagar, will merge it soon. |
asfgit
pushed a commit
that referenced
this pull request
May 2, 2017
### What is this PR for? After the merge of #2302 breaks authentication. ### What type of PR is it? [Hot Fix] ### Todos * [x] - Fix selenium logout issue (flaky test) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Prabhjyot Singh <[email protected]> Closes #2304 from prabhjyotsingh/hotfix/ImproveSession and squashes the following commits: 94ba9e7 [Prabhjyot Singh] check if modal window is present, and then close it f993b59 [Prabhjyot Singh] improve session (cherry picked from commit 6c4ccf3) Signed-off-by: Prabhjyot Singh <[email protected]>
prabhjyotsingh
added a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Dec 9, 2017
After the merge of apache#2302 breaks authentication. [Hot Fix] * [x] - Fix selenium logout issue (flaky test) * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Prabhjyot Singh <[email protected]> Closes apache#2304 from prabhjyotsingh/hotfix/ImproveSession and squashes the following commits: 94ba9e7 [Prabhjyot Singh] check if modal window is present, and then close it f993b59 [Prabhjyot Singh] improve session (cherry picked from commit 6c4ccf3) Signed-off-by: Prabhjyot Singh <[email protected]> Change-Id: Ie71a7b3879298b2eae2afc89ec6fa470e7f545c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
After the merge of #2302 breaks authentication.
What type of PR is it?
[Hot Fix]
Todos
Questions: