Skip to content

[ZEPPELIN-2467] Restoring second travis job functionality #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexanderShoshin wants to merge 3 commits into from
Closed

[ZEPPELIN-2467] Restoring second travis job functionality #2300

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0448c4a
added ability to exclude some unit tests using command line
AlexanderShoshin Apr 28, 2017
dfa332f
changed -Dtest flag to -Dtests.to.exclude and excluded unstable tests
AlexanderShoshin Apr 28, 2017
78771e9
made a comment about excluded tests
AlexanderShoshin May 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ matrix:

# Test core modules
- jdk: "oraclejdk7"
env: SCALA_VER="2.11" SPARK_VER="2.1.0" HADOOP_VER="2.6" PROFILE="-Pweb-ci -Pscalding -Phelium-dev -Pexamples -Pscala-2.11" BUILD_FLAG="package -Pbuild-distr -DskipRat" TEST_FLAG="verify -Pusing-packaged-distr -DskipRat" MODULES="-pl ${INTERPRETERS}" TEST_PROJECTS="-Dtest='!ZeppelinSparkClusterTest,!org.apache.zeppelin.spark.*' -DfailIfNoTests=false"
env: SCALA_VER="2.11" SPARK_VER="2.1.0" HADOOP_VER="2.6" PROFILE="-Pweb-ci -Pscalding -Phelium-dev -Pexamples -Pscala-2.11" BUILD_FLAG="package -Pbuild-distr -DskipRat" TEST_FLAG="verify -Pusing-packaged-distr -DskipRat" MODULES="-pl ${INTERPRETERS}" TEST_PROJECTS="-Dtests.to.exclude=**/ZeppelinSparkClusterTest.java,**/org.apache.zeppelin.spark.*,**/HeliumBundleFactoryTest.java,**/HeliumApplicationFactoryTest.java,**/NotebookTest.java,**/ZeppelinRestApiTest.java -DfailIfNoTests=false"

@felixcheung felixcheung Apr 30, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excluding the exact filename is a bit hard to maintain, I think? is there a way to exclude by subfolder/path?

@AlexanderShoshin AlexanderShoshin May 2, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that excluding tests by direct links is not the best way to solve the problem. But I couldn't think up anything more appropriate.

Excluding tests by packages will cause 15 more test files won't run because our 4 tests are located in 3 different packages in 2 different modules.

Maybe the better way will be to add an @Ignore annotation into test files instead of excluding them using travis configuration?

@Leemoonsoo Leemoonsoo May 2, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or how about add some verbose comments a line above to explain each file in tests.to.exclude flag?
The comments can mention JIRA issue. Then i think everyone can easily understand reason why the file is excluded and helps maintaining the travis.yml

@AlexanderShoshin AlexanderShoshin May 3, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment about excluded tests


# Test selenium with spark module for 1.6.3
- jdk: "oraclejdk7"
Expand Down
6 changes: 6 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@

<PermGen>64m</PermGen>
<MaxPermGen>512m</MaxPermGen>

<!-- to be able to exclude some tests using command line -->
<tests.to.exclude/>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -555,6 +558,9 @@
<version>${plugin.surefire.version}</version>
<configuration combine.children="append">
<argLine>-Xmx2g -Xms1g -Dfile.encoding=UTF-8</argLine>
<excludes>
<exclude>${tests.to.exclude}</exclude>
</excludes>
</configuration>
<!-- <excludes> <exclude>**/itest/**</exclude> </excludes> <executions>
<execution> <id>surefire-itest</id> <phase>integration-test</phase> <goals>
Expand Down