[ZEPPELIN-2468] Enable websocket without Origin if allowed.origins is * #2299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Iaad10a69983036e84b766a22fbc32113b926b60d
Member
|
LGTM |
Contributor
|
Thank you @elek for the fix. Tested on CentOS works well. LGTM. |
Member
|
Merge to master and branch-0.7 if no further comments. |
asfgit
pushed a commit
that referenced
this pull request
May 3, 2017
Change-Id: Iaad10a69983036e84b766a22fbc32113b926b60d ### What is this PR for? With ZEPPELIN-2288 we restored the check of the Origin field for websocket requests. Unfortunately the current implementation will deny the request if the Origin HTTP header is empty, even if the zeppelin.server.allowed.origins is * This patch enables websocket requests without Origin in the HTTP header if the zeppelin.server.allowed.origins=*. This fixes the work behind a restrictive reverse proxy (or behind Apache Knox) ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2468 ### How should this be tested? It could be tested with curl as described in ZEPPELIN-2288, but I added additional unit test, so the change has been covered on unit test level. ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NO Author: Elek, Márton <[email protected]> Closes #2299 from elek/ZEPPELIN-2468 and squashes the following commits: d95bb41 [Elek, Márton] [ZEPPELIN-2468] Enable websocket without Origin if allowed.origins is * (cherry picked from commit 73ae291) Signed-off-by: Lee moon soo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Iaad10a69983036e84b766a22fbc32113b926b60d
What is this PR for?
With ZEPPELIN-2288 we restored the check of the Origin field for websocket requests.
Unfortunately the current implementation will deny the request if the Origin HTTP header is empty, even if the zeppelin.server.allowed.origins is *
This patch enables websocket requests without Origin in the HTTP header if the zeppelin.server.allowed.origins=*. This fixes the work behind a restrictive reverse proxy (or behind Apache Knox)
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2468
How should this be tested?
It could be tested with curl as described in ZEPPELIN-2288, but I added additional unit test, so the change has been covered on unit test level.
Screenshots (if appropriate)
N/A
Questions: