Skip to content

Conversation

@r-kamath
Copy link
Member

What is this PR for?

Move cursor to second line for new paragraphs

What type of PR is it?

Improvement

Todos

  • - Task

What is the Jira issue?

ZEPPELIN-2459

How should this be tested?

For a new paragraph he initial cursor position should be on the second line.

Screenshots (if appropriate)

Before
screen shot 2017-04-26 at 10 27 48 pm

After
screen shot 2017-04-26 at 10 27 33 pm

Questions:

  • Does the licenses files need update? n/a
  • Is there breaking changes for older versions? n/a
  • Does this needs documentation? n/a

@prabhjyotsingh
Copy link
Contributor

Tested locally, LGTM.

@zjffdu
Copy link
Contributor

zjffdu commented Apr 29, 2017

BTW, could we change the cursor to a slim line ? I heard people complain about the cursor too thick

@r-kamath
Copy link
Member Author

r-kamath commented May 2, 2017

@zjffdu I think we should handle the cursor style in a different jira

@zjffdu
Copy link
Contributor

zjffdu commented May 2, 2017

@r-kamath Yeah, no problem.

@prabhjyotsingh
Copy link
Contributor

Merging this if no more discussion.

@asfgit asfgit closed this in 82c92d1 May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants