-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ZEPPELIN-753] TableData abstraction #1952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
42aacf7 to
781284a
Compare
|
@Leemoonsoo Nice to have abstracted table structure inside zeppelin. I think we can do a lot of things using this feature even i just glanced at! I will take look deeply and comment soon. |
781284a to
d85964b
Compare
|
@1ambda do you have any comment? |
|
Sorry for late reply. I was taking a look also recent resource related commit to understand fully.
@Leemoonsoo Now i have a question. (maybe this is future plan, but just for curiosity).
Thanks! |
|
@1ambda Thanks for taking a look. Regarding query directly over the TableData in the ResourcePool, it depends on each interpreter. The same approaches can be applied to all other interpreter that supports some types of plugin data source layer. |
|
@1ambda further discussion about "how interpreter access data from other interpreter" can be done in https://issues.apache.org/jira/browse/ZEPPELIN-2019. Merge this PR to master if no further discussions. |
What is this PR for?
This PR implements TableData abstraction that every interpreter can use to share data through resource pool.
TableData.java - Definition of TableData abstraction
TableDataProxy.java - Proxy object of TableData. This enables data access through ResourcePool
InterpreterResultTableData - Convert Table type interpret result into TableData. Each interpreter can implement it's own TableData abstraction. For example JDBCTableData, DataFrameTableData, and so on.
What type of PR is it?
Feature
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-753
How should this be tested?
Unittest included
Questions: