Skip to content

[ZEPPELIN-2007] Fix flaky test: ShellInterpreterTest#testShellTimeout #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Leemoonsoo wants to merge 1 commit into from
Closed

[ZEPPELIN-2007] Fix flaky test: ShellInterpreterTest#testShellTimeout #1939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions shell/src/test/java/org/apache/zeppelin/shell/ShellInterpreterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public class ShellInterpreterTest {
@Before
public void setUp() throws Exception {
Properties p = new Properties();
p.setProperty("shell.command.timeout.millisecs", "60000");
p.setProperty("shell.command.timeout.millisecs", "2000");
shell = new ShellInterpreter(p);

context = new InterpreterContext("", "1", null, "", "", null, null, null, null, null, null, null);
Expand Down Expand Up @@ -77,9 +77,9 @@ public void testInvalidCommand(){
@Test
public void testShellTimeout() {
if (System.getProperty("os.name").startsWith("Windows")) {
result = shell.interpret("timeout 61", context);
result = shell.interpret("timeout 4", context);
} else {
result = shell.interpret("sleep 61", context);
result = shell.interpret("sleep 4", context);
}

assertEquals(Code.INCOMPLETE, result.code());
Expand Down