Skip to content

[ZEPPELIN-1455] Fix flaky test: AbstractAngularElemTest #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Leemoonsoo wants to merge 1 commit into from
Closed

[ZEPPELIN-1455] Fix flaky test: AbstractAngularElemTest #1920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...-display/src/test/scala/org/apache/zeppelin/display/angular/AbstractAngularElemTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import org.apache.zeppelin.display.{AngularObject, AngularObjectRegistry, GUI}
import org.apache.zeppelin.interpreter._
import org.apache.zeppelin.user.AuthenticationInfo
import org.scalatest.concurrent.Eventually
import org.scalatest.time.{Seconds, Span}
import org.scalatest.{BeforeAndAfter, BeforeAndAfterEach, FlatSpec, Matchers}

/**
Expand Down Expand Up @@ -61,12 +62,12 @@ trait AbstractAngularElemTest
// click create thread for callback function to run. So it'll may not immediately invoked
// after click. therefore eventually should be
click(elem)
eventually {
eventually (timeout(Span(5, Seconds))) {
a should be(1)
}

click(elem)
eventually {
eventually (timeout(Span(5, Seconds))) {
a should be(2)
}

Expand Down Expand Up @@ -120,7 +121,7 @@ trait AbstractAngularElemTest

click(elem)

eventually { modelValue should be("value")}
eventually (timeout(Span(5, Seconds))) { modelValue should be("value")}
}


Expand Down