[ZEPPELIN-1821] Add HTTP client to elasticsearch interpreter #1902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Great contribution for elasticsearch interpreter! This PR enables us to support ES 5.0 easily! |
Member
|
@1ambda Can you review this PR deeply? |
Member
|
@bbonnin Recently we have fixed some flaky test on master branch. Could you try rebase and see if CI becomes green? |
Contributor
Author
|
After rebase, it looks better now, all is green ! |
Member
Member
|
LGTM @1ambda do you have any comment? |
10 tasks
|
When will this be merged? And which release will it be part of? |
Member
|
Works well as described.
there some comments. LGTM except that. |
1ambda
reviewed
Jan 27, 2017
| private final List<AggWrapper> aggregations = new LinkedList<>(); | ||
|
|
||
|
|
||
| // public ActionResponse source(String source) { |
Contributor
Author
There was a problem hiding this comment.
I have removed the commed code lines.
| return succeeded; | ||
| } | ||
|
|
||
| // public String getSource() { |
Member
|
CI failure looks unrelated, since it only removed commented-out code from last CI success. |
asfgit
pushed a commit
that referenced
this pull request
Jan 31, 2017
### What is this PR for? Add HTTP client to elasticsearch interpreter. ### What type of PR is it? Feature ### Todos * [X] - Source code * [X] - Tests * [X] - License * [X] - Docs ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1821 ### How should this be tested? * Start an Elasticsearch node * Configure the elasticsearch interpreter to use http * Create queries in a note using elasticsearch ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? Yes * Is there breaking changes for older versions? No * Does this needs documentation? Yes Author: Bruno Bonnin <[email protected]> Author: Bruno Bonnin <[email protected]> Closes #1902 from bbonnin/master and squashes the following commits: f5a539e [Bruno Bonnin] Remove commented code lines 86153a8 [Bruno Bonnin] Merge remote-tracking branch 'upstream/master' 2e1bbbd [Bruno Bonnin] Merge remote-tracking branch 'upstream/master' 19e888e [Bruno Bonnin] Remove bad code in test 523d155 [Bruno Bonnin] Replace Java 8 methods 6bcf369 [Bruno Bonnin] Fix issue with id containing special chars (/, #) 4e9812e [Bruno Bonnin] Merge elasticsearch/pom.xml 5a96ae0 [Bruno Bonnin] Merge branch 'master' into master e2365fb [Bruno Bonnin] Update elasticsearch/pom.xml 28b9805 [Bruno Bonnin] Update img 549db39 [Bruno Bonnin] Add HTTP client to elasticsearch interpreter f4c5ac3 [Bruno Bonnin] HTTP-based Elasticsearch client (cherry picked from commit e763b3b) Signed-off-by: Mina Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add HTTP client to elasticsearch interpreter.
What type of PR is it?
Feature
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1821
How should this be tested?
Screenshots (if appropriate)
Questions: