Skip to content

Conversation

@AhyoungRyu
Copy link
Contributor

@AhyoungRyu AhyoungRyu commented Dec 30, 2016

What is this PR for?

After #1567 merged we can get/set note permission info for a certain note. But this info is not described in anywhere for now. So I added "Security" section under docs/rest-api/rest-notebook.md.

And currently so many operations are placed under one section like below.

So I split them under each Note opersions, Paragraph operations, Cron jobs, and Permission section.

What type of PR is it?

Documentation

What is the Jira issue?

ZEPPELIN-1877

How should this be tested?

Please see the below screenshots :)

Screenshots (if appropriate)

screen shot 2017-01-10 at 5 41 51 pm
screen shot 2017-01-10 at 5 41 59 pm

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@AhyoungRyu
Copy link
Contributor Author

@anthonycorbacho As a creator of this operations, could you please help review this PR? :D

@AhyoungRyu
Copy link
Contributor Author

I updated this docs page again since REST API operations need to be listed as CRUD order. And removed unimplemented response code info as well. Please see the updated screenshot images :)

@minahlee
Copy link
Member

Nice improvement, LGTM

@AhyoungRyu
Copy link
Contributor Author

Thanks @minahlee!
Will merge if there are no more comments on this.

@asfgit asfgit closed this in 481eabb Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants