[ZEPPELIN-1650] Add mariadb, redshift configs and useful links to JDBC doc #1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I wanted to add drill settings in this PR but failed to test it. Anyone recently tried drill (1.8) using zeppelin 0.7-SNAPSHOT? |
Contributor
1ambda
force-pushed
the
jdbc-doc-improve
branch
from
73c2f0b to
f357147
Compare
Member
Author
|
@AhyoungRyu Thanks :) I merged it. Additionally, added a postgres section so that we can remove seperated postgres doc easily next time :) |
Don't make users confused when seperated postgre doc is removed
1ambda
force-pushed
the
jdbc-doc-improve
branch
from
f357147 to
6009eb9
Compare
Member
Author
|
@AhyoungRyu Updated postgres image :) Thanks again. CI is failing but it doens't related this PR i think. |
Contributor
|
@1ambda Yeah the changes are looks good to me. Thanks again for taking care of the docs. Definitely will help the JDBC users. |
tae-jun
pushed a commit
to tae-jun/zeppelin
that referenced
this pull request
Nov 23, 2016
…C doc ### What is this PR for? Add 2 JDBC configs and useful links to JDBC doc so that users can connect those backends easily :) ### What type of PR is it? Documentation ### Todos * [ ] - Task ### What is the Jira issue? [ZEPPELIN-1650](https://issues.apache.org/jira/browse/ZEPPELIN-1650) ### How should this be tested? See screenshots. ### Screenshots (if appropriate) <img width="706" alt="example_redshift" src="https://cloud.githubusercontent.com/assets/4968473/20208653/01b1e468-a833-11e6-9166-b05d15e9a5fe.png"> <img width="577" alt="example_mariadb" src="https://cloud.githubusercontent.com/assets/4968473/20208654/02b49a22-a833-11e6-9b29-5a61f2b6a4bb.png"> ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <[email protected]> Author: AhyoungRyu <[email protected]> Closes apache#1621 from 1ambda/jdbc-doc-improve and squashes the following commits: 0aab878 [1ambda] docs: Update postgres img ;) 6009eb9 [1ambda] docs: Add postgres section, hive2 doc link ce24af1 [AhyoungRyu] Make mariadb and redshift screenshots same with others 2fb5db1 [1ambda] docs: Add mariadb, redshift configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add 2 JDBC configs and useful links to JDBC doc so that users can connect those backends easily :)
What type of PR is it?
Documentation
Todos
What is the Jira issue?
ZEPPELIN-1650
How should this be tested?
See screenshots.
Screenshots (if appropriate)
Questions: