[ZEPPELIN-1003] Refactoring visualization #1529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leemoonsoo
force-pushed
the
refactoring_viz
branch
from
8a07952 to
13169b9
Compare
Leemoonsoo
force-pushed
the
refactoring_viz
branch
2 times, most recently
from
1268706 to
ce359e3
Compare
Leemoonsoo
changed the title
Leemoonsoo
force-pushed
the
refactoring_viz
branch
from
ce359e3 to
40f1ce8
Compare
Member
Author
|
I have created following issue https://issues.apache.org/jira/browse/ZEPPELIN-1619 for further work. This patch refactor build-in visualizations. Now most of codes for rending visualization took out from paragraph.controller.js and placed under Please review this change |
Member
Author
|
Merge if there're no further discussions. |
This was referenced Nov 9, 2016
asfgit
pushed a commit
that referenced
this pull request
Nov 15, 2016
### What is this PR for? After #1529, max number of rows limitation message is not displayed. ### What type of PR is it? Hot Fix ### Todos * [x] - display comment of tabledata ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1668 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes #1642 from Leemoonsoo/ZEPPELIN-1668 and squashes the following commits: 2d8d6ff [Lee moon soo] Display comment of table data
asfgit
pushed a commit
that referenced
this pull request
Nov 15, 2016
### What is this PR for? Downloaded csv, tsv file contains only header of table after #1529 is merged ### What type of PR is it? Hot Fix ### Todos * [x] - Fix csv/tsv download ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1654 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes #1643 from Leemoonsoo/ZEPPELIN-1654 and squashes the following commits: da08714 [Lee moon soo] Fix csv/tsv download
tae-jun
pushed a commit
to tae-jun/zeppelin
that referenced
this pull request
Nov 23, 2016
### What is this PR for? After apache#1529, max number of rows limitation message is not displayed. ### What type of PR is it? Hot Fix ### Todos * [x] - display comment of tabledata ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1668 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes apache#1642 from Leemoonsoo/ZEPPELIN-1668 and squashes the following commits: 2d8d6ff [Lee moon soo] Display comment of table data
tae-jun
pushed a commit
to tae-jun/zeppelin
that referenced
this pull request
Nov 23, 2016
### What is this PR for? Downloaded csv, tsv file contains only header of table after apache#1529 is merged ### What type of PR is it? Hot Fix ### Todos * [x] - Fix csv/tsv download ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1654 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes apache#1643 from Leemoonsoo/ZEPPELIN-1654 and squashes the following commits: da08714 [Lee moon soo] Fix csv/tsv download
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
As one of task of https://issues.apache.org/jira/browse/ZEPPELIN-1003, refactoring visualization code in the front-end side.
This patch try to abstract visualization in OOP style, and want to provide the same API for Helium package in the future.
Please feel free to leave any feedback about the implementation.
What type of PR is it?
Refactoring
Todos
What is the Jira issue?
this resolves part of https://issues.apache.org/jira/browse/ZEPPELIN-1003
Questions: