Skip to content

[ ZEPPELIN-1461 ] Doesn't display "description" value in interpreter creation page #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kjhong wants to merge 1 commit into from
Closed

[ ZEPPELIN-1461 ] Doesn't display "description" value in interpreter creation page #1522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions zeppelin-web/src/app/interpreter/interpreter.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,14 +291,15 @@
$scope.newInterpreterGroupChange = function() {
var el = _.pluck(_.filter($scope.availableInterpreters, {'name': $scope.newInterpreterSetting.group}),
'properties');
var properties = {};
for (var i = 0; i < el.length; i++) {
var intpInfo = el[i];
for (var key in intpInfo) {
properties[key] = {
value: intpInfo[key],
description: intpInfo[key].description
};
var properties = {};
for (var i = 0; i < el.length; i++) {
if (/.*(-description)$/.test(key)) {
continue;
}
properties[key] = {
value: intpInfo[key],
description: intpInfo[key + '-description']
};
}
}

Expand Down
2 changes: 2 additions & 0 deletions zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ private Properties convertInterpreterProperties(Map<String, InterpreterProperty>
Properties properties = new Properties();
for (String key : p.keySet()) {
properties.put(key, p.get(key).getValue());
properties.put(key + "-description", p.get(key).getDescription());
}
return properties;
}
Expand Down Expand Up @@ -346,6 +347,7 @@ private void registerInterpreters(List<RegisteredInterpreter> registeredInterpre
if (null != p) {
for (String key : p.keySet()) {
properties.setProperty(key, p.get(key).getValue());
properties.setProperty(key + "-description", p.get(key).getDescription());
}
}

Expand Down