[ZEPPELIN-1495] Add Good Practice #4 #1463
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@corneadoug Looks good 👍 |
Contributor
Author
|
:) Merging it then |
Contributor
|
I can't see the code block! It needs some escaping. |
Contributor
Author
|
@AhyoungRyu Nice catch, I also escaped those in Good Practice #3 |
Contributor
|
@corneadoug Yeah tested again and now the code blocks are shown well. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This Good Practice Guide promotes the usage of
ng-bindinstead of the classic{{}}syntax, to have a performance boost.What type of PR is it?
Documentation
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1495
How should this be tested?
Outline the steps to test the PR here.
Screenshots (if appropriate)
Questions: