Skip to content

[MINOR] Change Markdown class name from MarkdownInterpreter to Markdown #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
minahlee wants to merge 1 commit into from
Closed

[MINOR] Change Markdown class name from MarkdownInterpreter to Markdown #1449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...eppelin/markdown/MarkdownInterpreter.java → ...rg/apache/zeppelin/markdown/Markdown.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
import org.slf4j.LoggerFactory;

/** MarkdownInterpreter interpreter for Zeppelin. */
public class MarkdownInterpreter extends Interpreter {
private static final Logger LOGGER = LoggerFactory.getLogger(MarkdownInterpreter.class);
public class Markdown extends Interpreter {
private static final Logger LOGGER = LoggerFactory.getLogger(Markdown.class);

private MarkdownParser parser;

Expand All @@ -60,7 +60,7 @@ public String toString() {
public static final String PARSER_TYPE_PEGDOWN = "pegdown";
public static final String PARSER_TYPE_MARKDOWN4J = "markdown4j";

public MarkdownInterpreter(Properties property) {
public Markdown(Properties property) {
super(property);
}

Expand Down Expand Up @@ -114,7 +114,7 @@ public int getProgress(InterpreterContext context) {
@Override
public Scheduler getScheduler() {
return SchedulerFactory.singleton()
.createOrGetParallelScheduler(MarkdownInterpreter.class.getName() + this.hashCode(), 5);
.createOrGetParallelScheduler(Markdown.class.getName() + this.hashCode(), 5);
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion markdown/src/main/resources/interpreter-setting.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{
"group": "md",
"name": "md",
"className": "org.apache.zeppelin.markdown.MarkdownInterpreter",
"className": "org.apache.zeppelin.markdown.Markdown",
"properties": {
"markdown.parser.type": {
"envName": "MARKDOWN_PARSER_TYPE",
Expand Down
6 changes: 3 additions & 3 deletions markdown/src/test/java/org/apache/zeppelin/markdown/Markdown4jParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@

public class Markdown4jParserTest {

MarkdownInterpreter md;
Markdown md;

@Before
public void setUp() throws Exception {
Properties props = new Properties();
props.put(MarkdownInterpreter.MARKDOWN_PARSER_TYPE, MarkdownInterpreter.PARSER_TYPE_MARKDOWN4J);
md = new MarkdownInterpreter(props);
props.put(Markdown.MARKDOWN_PARSER_TYPE, Markdown.PARSER_TYPE_MARKDOWN4J);
md = new Markdown(props);
md.open();
}

Expand Down
6 changes: 3 additions & 3 deletions markdown/src/test/java/org/apache/zeppelin/markdown/PegdownParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@

public class PegdownParserTest {

MarkdownInterpreter md;
Markdown md;

@Before
public void setUp() throws Exception {
Properties props = new Properties();
props.put(MarkdownInterpreter.MARKDOWN_PARSER_TYPE, MarkdownInterpreter.PARSER_TYPE_PEGDOWN);
md = new MarkdownInterpreter(props);
props.put(Markdown.MARKDOWN_PARSER_TYPE, Markdown.PARSER_TYPE_PEGDOWN);
md = new Markdown(props);
md.open();
}

Expand Down