[ZEPPELIN-1422][zeppelin-interpreter] fix InterpreterProperty equals methods, add null check#1421
Closed
WeichenXu123 wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Member
|
LGTM and merge if there're no more discussions. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
in PR #1382,
there is a small bug that
InterpreterProperty.equalsdo not checknull.jdk lib request the
nullcheck otherwise it has the risk causing java collections operation throw exception.so I fix it.
What type of PR is it?
Bug Fix
Todos
N/A
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1422
How should this be tested?
existing test.
Screenshots (if appropriate)
Questions: