Skip to content

[ZEPPELIN-1417] Bugfix of "Connect to existing process" #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
astroshim wants to merge 2 commits into from
Closed

[ZEPPELIN-1417] Bugfix of "Connect to existing process" #1411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c84046c
change to create local interpreter when option is false.
Sep 7, 2016
0ff0f4e
remove isConnectExistingProcess()
Sep 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ public void createInterpretersForNote(InterpreterSetting interpreterSetting, Str
Interpreter interpreter;
for (InterpreterInfo info : interpreterInfos) {
if (option.isRemote()) {
if (option.isConnectExistingProcess()) {
if (option.isExistingProcess()) {
Copy link
Member

@Leemoonsoo Leemoonsoo Sep 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think InterpreterOption.isConnectExistingProcess() is no longer used in anywhere in the code base.
To avoid confusion between InterpreterOption.isConnectExistingProcess() and InterpreterOption. isExistingProcess(), @astroshim could you remove InterpreterOption.isConnectExistingProcess() method?

Copy link
Contributor Author

@astroshim astroshim Sep 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leemoonsoo You're right. I just removed. Thanks.

interpreter =
connectToRemoteRepl(noteId, info.getClassName(), option.getHost(), option.getPort(),
properties);
Expand Down
4 changes: 0 additions & 4 deletions zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterOption.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,6 @@ public void setPerNoteSession(boolean perNoteSession) {
this.perNoteSession = perNoteSession;
}

public boolean isConnectExistingProcess() {
return (host != null && port != -1);
}

public String getHost() {
return host;
}
Expand Down