Skip to content

[ZEPPELIN-808] Changed Permissions on Notebooks do not provide helpful error to user #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kavinkumarks wants to merge 3 commits into from
Closed

[ZEPPELIN-808] Changed Permissions on Notebooks do not provide helpful error to user #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f7cf67
Show information to the user when there are errors with related to
Sep 6, 2016
950ebda
Handle FileSystemException on running paragraph and show the relevant
Sep 12, 2016
21fd49a
Exit the run paragraph execution when there are errors with the notebook
Sep 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import com.google.gson.reflect.TypeToken;

import org.apache.commons.lang.StringUtils;
import org.apache.commons.vfs2.FileSystemException;
import org.apache.zeppelin.conf.ZeppelinConfiguration;
import org.apache.zeppelin.conf.ZeppelinConfiguration.ConfVars;
import org.apache.zeppelin.display.AngularObject;
Expand Down Expand Up @@ -1147,7 +1148,18 @@ private void runParagraph(NotebookSocket conn, HashSet<String> userAndRoles, Not
}

AuthenticationInfo subject = new AuthenticationInfo(fromMessage.principal);
note.persist(subject);

try {
note.persist(subject);
} catch (FileSystemException ex) {
LOG.error("Exception from run", ex);
conn.send(serializeMessage(new Message(OP.ERROR_INFO).put("info",
"Oops! There is something wrong with the notebook file system. "
+ "Please check the logs for more details.")));
// don't run the paragraph when there is error on persisting the note information
return;
}

try {
note.run(paragraphId);
} catch (Exception ex) {
Expand Down
15 changes: 15 additions & 0 deletions zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,21 @@ angular.module('zeppelinWebApp').factory('websocketEvents',
$rootScope.$broadcast('noteRevision', data);
} else if (op === 'INTERPRETER_BINDINGS') {
$rootScope.$broadcast('interpreterBindings', data);
} else if (op === 'ERROR_INFO') {
BootstrapDialog.show({
closable: false,
closeByBackdrop: false,
closeByKeyboard: false,
title: 'Details',
message: data.info.toString(),
buttons: [{
// close all the dialogs when there are error on running all paragraphs
label: 'Close',
action: function() {
BootstrapDialog.closeAll();
}
}]
});
}
});

Expand Down
3 changes: 2 additions & 1 deletion zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/socket/Message.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ public static enum OP {
SAVE_INTERPRETER_BINDINGS, // [c-s] save interpreter bindings
// @param noteID
// @param selectedSettingIds
INTERPRETER_BINDINGS // [s-c] interpreter bindings
INTERPRETER_BINDINGS, // [s-c] interpreter bindings
ERROR_INFO // [s-c] error information to be sent
}

public OP op;
Expand Down