[ZEPPELIN-1412] add support multiline for pythonErrorIn method on python interpreter#1407
[ZEPPELIN-1412] add support multiline for pythonErrorIn method on python interpreter#1407cloverhearts wants to merge 1 commit intoapache:masterfrom cloverhearts:dev/ZEPPELIN-1412
Conversation
|
Thank you for improvements, @cloverhearts Does it work with both, python2 and python3 ? Looks good to me. Although as discussed under ZEPPELIN-1360 - this approach have performance implications and this code most probably is going to be removed under ZEPPELIN-1325. Merging to master if there is no further discussions |
|
@bzz |
| boolean isError = false; | ||
| String[] outputMultiline = output.split("\n"); | ||
| Matcher errorMatcher; | ||
| for (String row : outputMultiline) { |
There was a problem hiding this comment.
should it look at only the last line?
There was a problem hiding this comment.
@felixcheung Sorry, Can you please explain in more detail?
There was a problem hiding this comment.
Sorry guys, I missed GH notifications on this discussion and merged it :\
What is this PR for?
currently, has not support multiline exception text on python interpreter.
for example:
is error.
but
is sucess (now)
to resolve this issue.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1412?jql=project%20%3D%20ZEPPELIN%20AND%20status%20%3D%20Open
How should this be tested?
added test case.
Questions: