[ZEPPELIN-1405] ConnectionPool for JDBCInterpreter. #1396

astroshim · 2016-09-02T09:07:53Z

What is this PR for?

This PR is for refactoring code for JDBCInterpreter.
There is no putting 'Connection' to 'propertyKeyUnusedConnectionListMap' anywhere in the original code.

What type of PR is it?

Improvement

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1405

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

astroshim · 2016-09-02T09:14:49Z

\cc @jongyoul Please review this PR if i misunderstand.

jongyoul · 2016-09-03T04:36:03Z

@astroshim It doesn't look completed. When are some connections closed? First of all, there's no code for closing connections.

astroshim · 2016-09-03T06:06:21Z

@jongyoul I will refactor the code to use connection pool.

jongyoul · 2016-09-03T06:24:25Z

In this PR or separately?

On Saturday, 3 September 2016, HyungSung [email protected] wrote:

@jongyoul https://github.com/jongyoul I will refactor the code to use
database pool.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1396 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADcflgJmeDQxwU2fRTGSZURNtH5EZb6Yks5qmQ5ngaJpZM4Jzgoo
.

이종열, Jongyoul Lee, 李宗烈
http://madeng.net

astroshim · 2016-09-03T06:28:56Z

I will do it in this PR and change the title this. :)

jongyoul · 2016-09-03T06:40:52Z

Good!!

On Saturday, 3 September 2016, HyungSung [email protected] wrote:

I will do it in this PR and change the title this. :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1396 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADcflk02U-1wmCZXO3P3cKSDLcjpISYAks5qmROygaJpZM4Jzgoo
.

이종열, Jongyoul Lee, 李宗烈
http://madeng.net

astroshim · 2016-09-05T16:16:47Z

\cc @jongyoul I changed some codes to use Connection Pool that is org.apache.commons.dbcp2, please review.

astroshim · 2016-09-06T06:38:09Z

I tested mysql, postgresql and hive.

jongyoul · 2016-09-06T06:57:59Z

Thanks! I'll look into it. btw, don't you have any problem when you were testing mysql?

astroshim · 2016-09-06T07:07:37Z

Thanks @jongyoul and there was no problem running mysql.

jongyoul · 2016-09-06T16:22:47Z

jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java


  private InterpreterResult executeSql(String propertyKey, String sql,
-      InterpreterContext interpreterContext) {
+                                       InterpreterContext interpreterContext) {


@astroshim It's not recommended. you should change your IDE setting :-)

ah.. okay i will

astroshim · 2016-09-08T03:29:58Z

ping

astroshim · 2016-09-09T08:46:28Z

re-trigger CI

astroshim · 2016-09-12T22:12:57Z

re-trigger CI

astroshim · 2016-09-23T08:42:47Z

CI has passed. please review.

### What is this PR for? This PR is for refactoring code for JDBCInterpreter. There is no putting 'Connection' to 'propertyKeyUnusedConnectionListMap' anywhere in the original code. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1405 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <[email protected]> Closes apache#1396 from astroshim/ZEPPELIN-1405 and squashes the following commits: b07e162 [astroshim] add checking connection is null f6998c2 [astroshim] Merge branch 'master' into ZEPPELIN-1405 1862ae6 [astroshim] Merge branch 'master' into ZEPPELIN-1405 efc2bfc [astroshim] rebase 21217a7 [astroshim] fix indentation. 4d4f85c [astroshim] refactoring code of close() 9f1e368 [astroshim] replace ConnectionPool 4dabbcc [astroshim] wip) changing to use dbcp 12dd7cb [astroshim] remove propertyKeyUnusedConnectionListMap map

remove propertyKeyUnusedConnectionListMap map

12dd7cb

astroshim changed the title ~~[ZEPPELIN-1405] Remove propertyKeyUnusedConnectionListMap variable in JDBCInterpreter~~ [ZEPPELIN-1405] ConnectionPool to JDBCInterpreter. Sep 4, 2016

wip) changing to use dbcp

4dabbcc

astroshim changed the title ~~[ZEPPELIN-1405] ConnectionPool to JDBCInterpreter.~~ [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter. Sep 4, 2016

astroshim changed the title ~~[ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.~~ [WIP] [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter. Sep 4, 2016

astroshim added 2 commits September 6, 2016 00:58

replace ConnectionPool

9f1e368

refactoring code of close()

4d4f85c

astroshim changed the title ~~[WIP] [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.~~ [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter. Sep 5, 2016

jongyoul reviewed Sep 6, 2016
View reviewed changes

fix indentation.

21217a7

astroshim closed this Sep 9, 2016

astroshim reopened this Sep 9, 2016

rebase

efc2bfc

astroshim closed this Sep 12, 2016

astroshim reopened this Sep 12, 2016

astroshim added 2 commits September 21, 2016 21:58

Merge branch 'master' into ZEPPELIN-1405

1862ae6

Merge branch 'master' into ZEPPELIN-1405

f6998c2

astroshim closed this Sep 22, 2016

astroshim reopened this Sep 22, 2016

add checking connection is null

b07e162

asfgit closed this in b24491b Sep 28, 2016

[ZEPPELIN-1405] ConnectionPool for JDBCInterpreter. #1396

[ZEPPELIN-1405] ConnectionPool for JDBCInterpreter. #1396

Uh oh!

Conversation

astroshim commented Sep 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is this PR for?

What type of PR is it?

What is the Jira issue?

Questions:

Uh oh!

astroshim commented Sep 2, 2016

Uh oh!

jongyoul commented Sep 3, 2016

Uh oh!

astroshim commented Sep 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jongyoul commented Sep 3, 2016

Uh oh!

astroshim commented Sep 3, 2016

Uh oh!

jongyoul commented Sep 3, 2016

Uh oh!

astroshim commented Sep 5, 2016

Uh oh!

astroshim commented Sep 6, 2016

Uh oh!

jongyoul commented Sep 6, 2016

Uh oh!

astroshim commented Sep 6, 2016

Uh oh!

jongyoul Sep 6, 2016

Choose a reason for hiding this comment

Uh oh!

astroshim Sep 7, 2016

Choose a reason for hiding this comment

Uh oh!

astroshim commented Sep 8, 2016

Uh oh!

astroshim commented Sep 9, 2016

Uh oh!

astroshim commented Sep 12, 2016

Uh oh!

astroshim commented Sep 23, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

astroshim commented Sep 2, 2016 •

edited

Loading

astroshim commented Sep 3, 2016 •

edited

Loading