rename r directory to 2BWJFTXKJ#1394
Closed
prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Contributor
Author
|
@echarles I'm assuming there was no specific reason to keep name of this directory as "R" and hence, renaming this to look like any other notebook. |
Member
|
@prabhjyotsingh yes, assumption is correct. At the time of the R interpreter dev, I was used to manually rename the note folder and edit the json to set the id the same value. This PR takes it back to the default layout (didn't test it, but checked that the id value in the json was also correct). LGTM |
Contributor
Author
|
Sure, Thank you. Will merge this if no more discussion. |
Member
Contributor
Author
|
Yes, I did both, rename the directory and https://github.com/prabhjyotsingh/zeppelin/blob/5993506b77be84d71ab730c2965572edd73e870e/notebook/2BWJFTXKJ/note.json#L1041 |
Member
|
Ah I missed the change. LGTM |
asfgit
pushed a commit
that referenced
this pull request
Sep 4, 2016
### What is this PR for? Rename "R" directory to "2BWJFTXKJ" under notebook directory to make it look like all other notebooks. ### What type of PR is it? [Refactoring] ### Todos * [x] - Rename ### What is the Jira issue? * N/A ### How should this be tested? goto $ZEPPELIN_HOME/notebook directory, under this there should be no "R" directory. On starting zeppelin-server, the existing notebook should be listed. ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes #1394 from prabhjyotsingh/renameRDirectory and squashes the following commits: 5993506 [Prabhjyot Singh] rename r directory to 2BWJFTXKJ (cherry picked from commit d497348) Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Rename "R" directory to "2BWJFTXKJ" under notebook directory to make it look like all other notebooks.
What type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
How should this be tested?
goto $ZEPPELIN_HOME/notebook directory, under this there should be no "R" directory.
On starting zeppelin-server, the existing notebook should be listed.
Screenshots (if appropriate)
N/A
Questions: