[ZEPPELIN-1116]send out more exception msg#1379
Closed
passionke wants to merge 3 commits intoapache:masterfrom
passionke:passionke-jdbc-better-errortips
Closed
[ZEPPELIN-1116]send out more exception msg#1379passionke wants to merge 3 commits intoapache:masterfrom passionke:passionke-jdbc-better-errortips
passionke wants to merge 3 commits intoapache:masterfrom
passionke:passionke-jdbc-better-errortips
Conversation
in sql case, the real error exception stack is hide in e.getCause.getCause. use printStackTrace to receive all the stack trace make people know true reason.
Member
|
LGTM |
add java.io
Member
|
I have a question. Is it OK not to close |
Contributor
Author
|
thanks your advice, It seems that the memory-based ByteArrayOutputStream do not need a close() method to release resources. Here is an answer at http://stackoverflow.com/questions/2330569/closing-a-bytearrayoutputstream-has-no-effect |
Member
|
@passionke Sorry for the late reply. Thanks for the comment. LGTM. |
Member
|
@passionke Can you tell me your jira id? |
Member
|
I found you by your email. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
better jdbc error msg make people know the true error clearly.
What type of PR is it?
Improvement
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1116
How should this be tested?
Outline the steps to test the PR here.
Screenshots (if appropriate)
Questions:
in sql case, the real error exception stack is hide in e.getCause.getCause. use printStackTrace to receive all the stack trace make people know true reason.