[ZEPPELIN-1383][ Interpreters][r-interpreter] remove SparkInterpreter.getSystemDefault and update relative code#1372
Closed
WeichenXu123 wants to merge 2 commits intoapache:masterfrom
Conversation
WeichenXu123
force-pushed
the
remove_spark_interpreter_getSystemDefault
branch
from
cdea57c to
841b757
Compare
Contributor
Author
|
cc @jongyoul @Leemoonsoo Thanks! |
| } | ||
|
|
||
| public InterpreterPropertyBuilder add(String name, | ||
| String envName, |
Member
There was a problem hiding this comment.
Vertical align is not recommended. Could you fix it?
Contributor
Author
There was a problem hiding this comment.
OK. Does the code has 100 character per-line limit ? If exceed which format is expected ? thanks~
Contributor
Author
There was a problem hiding this comment.
fix it like folllowing:
public InterpreterPropertyBuilder add(String name, String envName, String propertyName, String defaultValue, String description)
thanks!
Member
|
I think it's enough for my purpose. Thanks. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
clean some redundant code:
remove
SparkInterpreter.getSystemDefaultmethods,and replace it with
InterpreterProperty.getValueWhat type of PR is it?
Improvement
Todos
N/A
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1383
remove SparkInterpreter.getSystemDefault and update relative code
How should this be tested?
Existing tests.
Screenshots (if appropriate)
Questions: