Skip to content

[ZEPPELIN-1040] Show the time when the result is updated#1367

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

[ZEPPELIN-1040] Show the time when the result is updated#1367
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Aug 26, 2016

What is this PR for?

As per existing usage, the time shown in end of each paragraph is the time the paragraph is updated not when the paragraph is actually executed/run.

" Took 10 sec. Last updated by anonymous at August 26 2016, 1:52:01 PM. "

PR is aimed at changing the existing usage to show when the paragraph is last executed as this gives clarification to users about the executed time of paragraph

What type of PR is it?

Improvement

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1040

How should this be tested?

  1. Start the server and create a new note book
  2. create a new paragraph and execute the paragraph
  3. Now rerun the paragraph, the time should get updated now inline with execution of the paragraph

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@ghost ghost closed this Aug 29, 2016
@ghost ghost reopened this Aug 29, 2016
@corneadoug
Copy link
Contributor

The CI failure is irrelevant, Selenium Build is Green, and at least one Test Build is green.
LGTM

@corneadoug
Copy link
Contributor

Merging in Master & branch-0.6 if there is no more discussions

@asfgit asfgit closed this in f1a2471 Sep 1, 2016
asfgit pushed a commit that referenced this pull request Sep 1, 2016
As per existing usage, the time shown in end of each paragraph is the time the paragraph is updated not when the paragraph is actually executed/run.

_" Took 10 sec. Last updated by anonymous at **August 26 2016, 1:52:01 PM.** "_

PR is aimed at changing the existing usage to show when the paragraph is last executed as this gives  clarification to users about the executed time of paragraph

 Improvement

* [ ] - Task

https://issues.apache.org/jira/browse/ZEPPELIN-1040

1. Start the server and create a new note book
2. create a new paragraph and execute the paragraph
3. Now rerun the paragraph, the time should get updated now inline with execution of the paragraph

* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: rajarajan-g <rajarajan.ganesan@imaginea.com>

Closes #1367 from rajarajan-g/ZEPPELIN-1040 and squashes the following commits:

d30f1b2 [rajarajan-g] code changed for showing last run time after execution of paragraph

(cherry picked from commit f1a2471)
Signed-off-by: Damien CORNEAU <corneadoug@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants