[ZEPPELIN-1366] Removed legacy JDBC alias by jongyoul · Pull Request #1360 · apache/zeppelin

jongyoul · 2016-08-25T03:31:40Z

What is this PR for?

Removing old JDBC sugar

What type of PR is it?

[Feature]

Todos

- Removed codes to check jdbc alias enabled

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1366

How should this be tested?

No longer available
- %jdbc(mysql) -> %mysql

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? Yes
Does this needs documentation? Yes, but I don't know where the proper location is.

bzz · 2016-08-26T01:56:37Z

LGTM. But this needs to be rebased on latest master - seems like there is a conflict now.

Is there breaking changes for older versions? Yes

Do we have a change-log or something where we can keep track of breaking changes to highlight them in the release?

Does this needs documentation? Yes, but I don't know where the proper location is.

@minahlee @AhyoungRyu what do you think is the best location for such docs?

Leemoonsoo · 2016-08-26T02:06:48Z

I think it changes way of configuration. From single jdbc interpreter setting manages multiple jdbc connection, to individual interpreter setting manage single jdbc connection.

How about remove non-default jdbc connection configurations from default properties and documentation?
https://github.com/apache/zeppelin/blob/master/jdbc/src/main/resources/interpreter-setting.json
https://github.com/apache/zeppelin/blob/master/docs/interpreter/jdbc.md

And incompatible changes can be guided in https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md

jongyoul · 2016-08-26T03:57:24Z

@bzz @Leemoonsoo Thanks, I don't know the proper location to describe the changes actually. I'll also update upgrade.md. And about changing a behaviour of JDBC, in case of %jdbc(mysql), I thought it's not related to this issue directly, then I'll make another PR for handling that. We don't need to multiple configurations due to interpreter aliases.

AhyoungRyu · 2016-08-26T05:05:02Z

@jongyoul Then can we use JDBC interpreter as described in How to use section like before? I just wondered :D

jongyoul · 2016-08-29T03:00:42Z

@AhyoungRyu Sure, That works for now. I'll remove those docs after I remove the prefix feature.

jongyoul · 2016-08-29T09:04:09Z

Finished rebase. Ci failure is unrelated. Merging if there's no more discussion.

Leemoonsoo · 2016-08-30T21:01:30Z

docs/install/upgrade.md

+
+# Breaking Changes
+## Upgrading from 0.6.x to 0.7.0
+- Mapping from `%jdbc(prefix)` to `%prefix` is no longer available. You can set multiple interpreters with same interpreter group.


nit: How about "Instead, you can use %[interpreter alias] with multiple interpreter setttings on GUI", instead of "You can set multiple interpreters with same interpreter group"?

Yeah, that looks more kind

jongyoul · 2016-08-31T17:27:03Z

Addressed upgrade.md

Leemoonsoo · 2016-08-31T23:28:39Z

Thanks LGTM

jongyoul · 2016-09-02T02:00:40Z

I've rebased it because of resolving conflict. I'll merge it soon.

…mprove JDBC docs ### What is this PR for? Currently we can use `%jdbc(prefix)` for multi database connections(e.g. configuring both postgresql and hive in one JDBC interpreter). But after #1360 merged, Zeppelin doesn't support `%jdbc(prefix)` to `%prefix` anymore. So auto-prefix feature is not working for `%jdbc(prefix)`. The auto-prefix only works for `%prefix` now. Considering this status, it would be better we remove the JDBC connection examples in `jdbc/interpreter-setting.json` (this is come from #1096) so that users can create several JDBC interpreters instead of using multiple connections with one JDBC interpreter. I removed the related contents in `jdbc.md` as well. Also, the contents of [current JDBC documentation page](http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/jdbc.html) is quite confusing and unorganized. So I updated the contents with some screenshot images to guide "How to create JDBC interpreter", "How to edit the interpreter properties for the connection", "How to use `%prefix` with the interpreter", and so on. ### What type of PR is it? Improvement & Documentation ### What is the Jira issue? [ZEPPELIN-1489](https://issues.apache.org/jira/browse/ZEPPELIN-1489) ### How should this be tested? * Removing example properties in `interpreter-setting.json` 1. after applying this patch and build with `mvn clean package -DskipTests -Pspark-1.6 -pl 'jdbc,zeppelin-interpreter,zeppelin-web,zeppelin-server,zeppelin-zengine,zeppelin-display'` 2. create JDBC interpreter and check whether the example settings are gone or not * JDBC docs 1. Build only `docs/` dir as described in [here](https://github.com/apache/zeppelin/blob/master/docs/README.md#build-documentation) 2. Go to `interpreter -> JDBC` and just compare this locally builded page with [the original JDBC page](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/jdbc.html) ### Screenshots (if appropriate) - Before <img width="1579" alt="before" src="https://cloud.githubusercontent.com/assets/10060731/19045323/1ff0c706-89d3-11e6-9b6f-dc75877f81f3.png"> - After <img width="944" alt="screen shot 2016-10-04 at 1 05 00 am" src="https://cloud.githubusercontent.com/assets/10060731/19045324/24a9187a-89d3-11e6-90d6-b80acbc6af7c.png"> - Some parts of updated JDBC docs Since many contents are changed, it would be better to build `docs/` locally to review all of the change. <img width="695" alt="screen shot 2016-10-04 at 12 36 39 am" src="https://cloud.githubusercontent.com/assets/10060731/19043794/9d9a32fc-89cc-11e6-9d15-f6036a1b738e.png"> <img width="704" alt="screen shot 2016-10-04 at 12 36 59 am" src="https://cloud.githubusercontent.com/assets/10060731/19043800/a62fc90e-89cc-11e6-976d-5c697729eca4.png"> <img width="677" alt="screen shot 2016-10-04 at 12 37 31 am" src="https://cloud.githubusercontent.com/assets/10060731/19043807/acbc9766-89cc-11e6-8c73-eab1cc18440b.png"> <img width="688" alt="screen shot 2016-10-04 at 12 37 43 am" src="https://cloud.githubusercontent.com/assets/10060731/19043816/b06b5690-89cc-11e6-9298-a20b49fea622.png"> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? yes Author: AhyoungRyu <ahyoungryu@apache.org> Closes #1480 from AhyoungRyu/ZEPPELIN-1489 and squashes the following commits: 76bf55e [AhyoungRyu] Minor update d5aaa97 [AhyoungRyu] Remove useless screenshot images c6f9ed4 [AhyoungRyu] Add screenshot images 99a18e2 [AhyoungRyu] Remove jdbc setting examples in interpreter-setting.json 050ecc0 [AhyoungRyu] Update jdbc.md 20da102 [AhyoungRyu] Redshit -> Redshift in JDBCInterpreter.java

…mprove JDBC docs ### What is this PR for? Currently we can use `%jdbc(prefix)` for multi database connections(e.g. configuring both postgresql and hive in one JDBC interpreter). But after apache#1360 merged, Zeppelin doesn't support `%jdbc(prefix)` to `%prefix` anymore. So auto-prefix feature is not working for `%jdbc(prefix)`. The auto-prefix only works for `%prefix` now. Considering this status, it would be better we remove the JDBC connection examples in `jdbc/interpreter-setting.json` (this is come from apache#1096) so that users can create several JDBC interpreters instead of using multiple connections with one JDBC interpreter. I removed the related contents in `jdbc.md` as well. Also, the contents of [current JDBC documentation page](http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/jdbc.html) is quite confusing and unorganized. So I updated the contents with some screenshot images to guide "How to create JDBC interpreter", "How to edit the interpreter properties for the connection", "How to use `%prefix` with the interpreter", and so on. ### What type of PR is it? Improvement & Documentation ### What is the Jira issue? [ZEPPELIN-1489](https://issues.apache.org/jira/browse/ZEPPELIN-1489) ### How should this be tested? * Removing example properties in `interpreter-setting.json` 1. after applying this patch and build with `mvn clean package -DskipTests -Pspark-1.6 -pl 'jdbc,zeppelin-interpreter,zeppelin-web,zeppelin-server,zeppelin-zengine,zeppelin-display'` 2. create JDBC interpreter and check whether the example settings are gone or not * JDBC docs 1. Build only `docs/` dir as described in [here](https://github.com/apache/zeppelin/blob/master/docs/README.md#build-documentation) 2. Go to `interpreter -> JDBC` and just compare this locally builded page with [the original JDBC page](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/jdbc.html) ### Screenshots (if appropriate) - Before <img width="1579" alt="before" src="https://cloud.githubusercontent.com/assets/10060731/19045323/1ff0c706-89d3-11e6-9b6f-dc75877f81f3.png"> - After <img width="944" alt="screen shot 2016-10-04 at 1 05 00 am" src="https://cloud.githubusercontent.com/assets/10060731/19045324/24a9187a-89d3-11e6-90d6-b80acbc6af7c.png"> - Some parts of updated JDBC docs Since many contents are changed, it would be better to build `docs/` locally to review all of the change. <img width="695" alt="screen shot 2016-10-04 at 12 36 39 am" src="https://cloud.githubusercontent.com/assets/10060731/19043794/9d9a32fc-89cc-11e6-9d15-f6036a1b738e.png"> <img width="704" alt="screen shot 2016-10-04 at 12 36 59 am" src="https://cloud.githubusercontent.com/assets/10060731/19043800/a62fc90e-89cc-11e6-976d-5c697729eca4.png"> <img width="677" alt="screen shot 2016-10-04 at 12 37 31 am" src="https://cloud.githubusercontent.com/assets/10060731/19043807/acbc9766-89cc-11e6-8c73-eab1cc18440b.png"> <img width="688" alt="screen shot 2016-10-04 at 12 37 43 am" src="https://cloud.githubusercontent.com/assets/10060731/19043816/b06b5690-89cc-11e6-9298-a20b49fea622.png"> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? yes Author: AhyoungRyu <ahyoungryu@apache.org> Closes apache#1480 from AhyoungRyu/ZEPPELIN-1489 and squashes the following commits: 76bf55e [AhyoungRyu] Minor update d5aaa97 [AhyoungRyu] Remove useless screenshot images c6f9ed4 [AhyoungRyu] Add screenshot images 99a18e2 [AhyoungRyu] Remove jdbc setting examples in interpreter-setting.json 050ecc0 [AhyoungRyu] Update jdbc.md 20da102 [AhyoungRyu] Redshit -> Redshift in JDBCInterpreter.java

jongyoul force-pushed the ZEPPELIN-1366 branch from 21abf3f to fa52869 Compare August 29, 2016 07:54

Leemoonsoo reviewed Aug 30, 2016
View reviewed changes

jongyoul added 5 commits September 1, 2016 19:40

Resolved codes conflicted

9f46bbd

Removed test for jdbc sugar

e52521f

Updated docs for breaking changes

929bad2

Removed effectiveText and related test

302825c

Changed description

f9df86e

jongyoul force-pushed the ZEPPELIN-1366 branch from d4d3eee to f9df86e Compare September 1, 2016 10:42

asfgit closed this in fe3dbdb Sep 2, 2016

AhyoungRyu mentioned this pull request Oct 3, 2016

[ZEPPELIN-1489] Remove jdbc-like interpreter example properties and improve JDBC docs #1480

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ZEPPELIN-1366] Removed legacy JDBC alias#1360

[ZEPPELIN-1366] Removed legacy JDBC alias#1360
jongyoul wants to merge 5 commits intoapache:masterfrom
jongyoul:ZEPPELIN-1366

jongyoul commented Aug 25, 2016

Uh oh!

bzz commented Aug 26, 2016 •

edited

Loading

Uh oh!

Leemoonsoo commented Aug 26, 2016

Uh oh!

jongyoul commented Aug 26, 2016

Uh oh!

AhyoungRyu commented Aug 26, 2016

Uh oh!

jongyoul commented Aug 29, 2016 •

edited

Loading

Uh oh!

jongyoul commented Aug 29, 2016

Uh oh!

Leemoonsoo Aug 30, 2016

Uh oh!

jongyoul Aug 31, 2016

Uh oh!

jongyoul commented Aug 31, 2016

Uh oh!

Leemoonsoo commented Aug 31, 2016

Uh oh!

jongyoul commented Sep 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jongyoul commented Aug 25, 2016

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

Uh oh!

bzz commented Aug 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Leemoonsoo commented Aug 26, 2016

Uh oh!

jongyoul commented Aug 26, 2016

Uh oh!

AhyoungRyu commented Aug 26, 2016

Uh oh!

jongyoul commented Aug 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jongyoul commented Aug 29, 2016

Uh oh!

Leemoonsoo Aug 30, 2016

Choose a reason for hiding this comment

Uh oh!

jongyoul Aug 31, 2016

Choose a reason for hiding this comment

Uh oh!

jongyoul commented Aug 31, 2016

Uh oh!

Leemoonsoo commented Aug 31, 2016

Uh oh!

jongyoul commented Sep 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bzz commented Aug 26, 2016 •

edited

Loading

jongyoul commented Aug 29, 2016 •

edited

Loading