Skip to content

[ZEPPELIN-1365] Error of Zeppelin Application in development mode.#1358

Closed
astroshim wants to merge 1 commit intoapache:masterfrom
astroshim:ZEPPELIN-1365
Closed

[ZEPPELIN-1365] Error of Zeppelin Application in development mode.#1358
astroshim wants to merge 1 commit intoapache:masterfrom
astroshim:ZEPPELIN-1365

Conversation

@astroshim
Copy link
Contributor

What is this PR for?

This PR fixes the bug of running application in development mode.

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1365

How should this be tested?

  1. run zeppelin
  2. run org.apache.zeppelin.interpreter.dev.ZeppelinApplicationDevServer in development mode.
    (http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelinapplication.html)
  3. and run paragraph like screenshot.

Screenshots (if appropriate)

image

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@astroshim
Copy link
Contributor Author

re-trigger CI

@astroshim astroshim closed this Aug 26, 2016
@astroshim astroshim reopened this Aug 26, 2016
@AhyoungRyu
Copy link
Contributor

@astroshim Definitely in the latest master branch, I faced the below exception when I tried to run org.apache.zeppelin.interpreter.dev.ZeppelinApplicationDevServer in my IDE.

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 0
    at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer.main(RemoteInterpreterServer.java:136)

Maybe that's why you created this patch.

So I tried to test this PR with below steps

  1. Build again with this patch: mvn clean package -DskipTests
  2. Restart Zeppelin: ./bin/zeppelin-daemon.sh restart
  3. Run org.apache.zeppelin.interpreter.dev.ZeppelinApplicationDevServer in my IntelliJ -> Successfully started
  4. Run %spark new java.util.Date -> Nothing happened. I can't see the above Helium icons. Only Spark repl result was printed like res0: java.util.Date = Sun Aug 28 22:31:32 KST 2016. (I'm using Spark 2.0.)

Did I miss something? ㅠ_ㅠ

@astroshim
Copy link
Contributor Author

@AhyoungRyu Thank you for reviewing!!
Did you clear your browser cache?

@AhyoungRyu
Copy link
Contributor

@astroshim Yeah I did but still same :(

@AhyoungRyu
Copy link
Contributor

@astroshim I rebuild with mvn clean package -DskipTests -Pexamples and it works. I should've attached -Pexamples. Now I can see the Helium icon :)

Anyway I checked ArrayIndexOutOfBoundsException is gone with this patch. LGTM 👍

@bzz
Copy link
Member

bzz commented Aug 29, 2016

Looks great to me!

Merging to master if there is no further discussion.

@astroshim
Copy link
Contributor Author

ping

@asfgit asfgit closed this in c580a82 Sep 1, 2016
asfgit pushed a commit that referenced this pull request Sep 1, 2016
### What is this PR for?
This PR fixes the bug of running application in development mode.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1365

### How should this be tested?
1. run zeppelin
2. run org.apache.zeppelin.interpreter.dev.ZeppelinApplicationDevServer in development mode.
(http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelinapplication.html)
3. and run paragraph like screenshot.

### Screenshots (if appropriate)
![image](https://cloud.githubusercontent.com/assets/3348133/17935588/d95ec2de-6a56-11e6-84d9-19030984411d.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: astroshim <hsshim@nflabs.com>

Closes #1358 from astroshim/ZEPPELIN-1365 and squashes the following commits:

9f640e5 [astroshim] add argument check.

(cherry picked from commit c580a82)
Signed-off-by: Damien CORNEAU <corneadoug@gmail.com>
@corneadoug
Copy link
Contributor

@astroshim You ping, I merge :)

@astroshim
Copy link
Contributor Author

Thank you @corneadoug

@mikhaildubkov
Copy link

@astroshim ,

Once I checkout branch-0,6 I'm unable to build project due to compilation error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project zeppelin-interpreter: Compilation failure
[ERROR] /zeppelin/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[35,43] package org.apache.zeppelin.interpreter.dev does not exist

Am I wrong with something or dev package really does not exists on branch-0.6 ?

@astroshim
Copy link
Contributor Author

@mikhaildubkov dev doesn't exists on 0.6.x so you should use master branch for this.
Thanks.

@mikhaildubkov
Copy link

@astroshim i guess it would be better just replace ZeppelinDevServer.DEFAULT_TEST_INTERPRETER_PORT by its int value for branch-0.6 to avoid necessary change for project build.

@Leemoonsoo
Copy link
Member

@corneadoug This PR shouldn't be merged to branch-0.6. Could you revert related commit from branch-0.6 ?

@corneadoug
Copy link
Contributor

@Leemoonsoo Sure, I merged in 0.6 since it was the fixed version in JIRA

@astroshim
Copy link
Contributor Author

Sorry maybe it's my mistake to set jira version.

@corneadoug
Copy link
Contributor

@Leemoonsoo Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments