[ZEPPELIN-1365] Error of Zeppelin Application in development mode.#1358
[ZEPPELIN-1365] Error of Zeppelin Application in development mode.#1358astroshim wants to merge 1 commit intoapache:masterfrom
Conversation
|
re-trigger CI |
|
@astroshim Definitely in the latest master branch, I faced the below exception when I tried to run Maybe that's why you created this patch. So I tried to test this PR with below steps
Did I miss something? ㅠ_ㅠ |
|
@AhyoungRyu Thank you for reviewing!! |
|
@astroshim Yeah I did but still same :( |
|
@astroshim I rebuild with Anyway I checked |
|
Looks great to me! Merging to master if there is no further discussion. |
|
ping |
### What is this PR for? This PR fixes the bug of running application in development mode. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1365 ### How should this be tested? 1. run zeppelin 2. run org.apache.zeppelin.interpreter.dev.ZeppelinApplicationDevServer in development mode. (http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelinapplication.html) 3. and run paragraph like screenshot. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <hsshim@nflabs.com> Closes #1358 from astroshim/ZEPPELIN-1365 and squashes the following commits: 9f640e5 [astroshim] add argument check. (cherry picked from commit c580a82) Signed-off-by: Damien CORNEAU <corneadoug@gmail.com>
|
@astroshim You ping, I merge :) |
|
Thank you @corneadoug |
|
Once I checkout branch-0,6 I'm unable to build project due to compilation error: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project zeppelin-interpreter: Compilation failure Am I wrong with something or dev package really does not exists on branch-0.6 ? |
|
@mikhaildubkov |
|
@astroshim i guess it would be better just replace ZeppelinDevServer.DEFAULT_TEST_INTERPRETER_PORT by its int value for branch-0.6 to avoid necessary change for project build. |
|
@corneadoug This PR shouldn't be merged to branch-0.6. Could you revert related commit from branch-0.6 ? |
|
@Leemoonsoo Sure, I merged in 0.6 since it was the fixed version in JIRA |
|
Sorry maybe it's my mistake to set jira version. |
|
@Leemoonsoo Done |
What is this PR for?
This PR fixes the bug of running application in development mode.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1365
How should this be tested?
(http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelinapplication.html)
Screenshots (if appropriate)
Questions: