[ZEPPELIN-1287][branch-0.6] No need to call print to display output in PythonInterpreter#1320
Closed
minahlee wants to merge 2 commits intoapache:branch-0.6from
Closed
[ZEPPELIN-1287][branch-0.6] No need to call print to display output in PythonInterpreter#1320minahlee wants to merge 2 commits intoapache:branch-0.6from
minahlee wants to merge 2 commits intoapache:branch-0.6from
Conversation
Member
Author
|
\cc @zjffdu for review |
Member
Member
Author
|
@bzz Thanks for taking care of JIRA issue! |
| // possible that the output contains the kind of pattern itself, e.g. print("...") | ||
| result = new InterpreterResult(Code.SUCCESS, output.replaceAll("\\.\\.\\.", "")); | ||
| return result; | ||
| } |
Contributor
There was a problem hiding this comment.
return it directly ?
return new InterpreterResult(Code.SUCCESS, output.replaceAll("\\.\\.\\.", ""));
Contributor
|
Just one minor code style issue, rest LGTM, Thanks @minahlee for taking over this. |
Member
Author
|
@zjffdu Thanks for review! |
asfgit
pushed a commit
that referenced
this pull request
Aug 12, 2016
…n PythonInterpreter ### What is this PR for? Implement #1278 to merge branch-0.6 ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-1287](https://issues.apache.org/jira/browse/ZEPPELIN-1287) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Mina Lee <minalee@apache.org> Closes #1320 from minahlee/branch-0.6_ZEPPELIN-1287 and squashes the following commits: f99f8aa [Mina Lee] return result directly ac83b14 [Mina Lee] No need to call print to display output in PythonInterpreter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Implement #1278 to merge branch-0.6
What type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-1287
Questions: