[ZEPPELIN-1300] Implement SparkInterpreter.completion for scala 2.11#1291
Closed
Leemoonsoo wants to merge 5 commits intoapache:masterfrom
Closed
[ZEPPELIN-1300] Implement SparkInterpreter.completion for scala 2.11#1291Leemoonsoo wants to merge 5 commits intoapache:masterfrom
Leemoonsoo wants to merge 5 commits intoapache:masterfrom
Conversation
cf532d3 to
1e04ef3
Compare
1e04ef3 to
0fefc6d
Compare
2d38456 to
7edc209
Compare
Member
Author
|
CI is green. |
Member
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Aug 7, 2016
SparkInterpreter misses code completion for scala 2.11 This PR make code completion works with spark 2.0 and scala 2.11 Improvement * [x] - Implement code completion for scala 2.11 * [x] - add unittest https://issues.apache.org/jira/browse/ZEPPELIN-1300 Unittest included. Try `ctrl + .` in your %spark paragraph  * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes #1291 from Leemoonsoo/ZEPPELIN-1300 and squashes the following commits: 7edc209 [Lee moon soo] Support scala 2.11.7 as well as 2.11.8 27c572b [Lee moon soo] add log message when completer not found 909b44b [Lee moon soo] find class silently 9ecbe70 [Lee moon soo] Add create completer based on class existance 0fefc6d [Lee moon soo] Implement SparkInterpreter.completion for scala 2.11 (cherry picked from commit 01beb54) Signed-off-by: Lee moon soo <moon@apache.org>
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? SparkInterpreter misses code completion for scala 2.11 This PR make code completion works with spark 2.0 and scala 2.11 ### What type of PR is it? Improvement ### Todos * [x] - Implement code completion for scala 2.11 * [x] - add unittest ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1300 ### How should this be tested? Unittest included. Try `ctrl + .` in your %spark paragraph ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes apache#1291 from Leemoonsoo/ZEPPELIN-1300 and squashes the following commits: 7edc209 [Lee moon soo] Support scala 2.11.7 as well as 2.11.8 27c572b [Lee moon soo] add log message when completer not found 909b44b [Lee moon soo] find class silently 9ecbe70 [Lee moon soo] Add create completer based on class existance 0fefc6d [Lee moon soo] Implement SparkInterpreter.completion for scala 2.11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
SparkInterpreter misses code completion for scala 2.11
This PR make code completion works with spark 2.0 and scala 2.11
What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1300
How should this be tested?
Unittest included.
Try
ctrl + .in your %spark paragraphScreenshots (if appropriate)
Questions: