Skip to content

[ZEPPELIN-1300] Implement SparkInterpreter.completion for scala 2.11#1291

Closed
Leemoonsoo wants to merge 5 commits intoapache:masterfrom
Leemoonsoo:ZEPPELIN-1300
Closed

[ZEPPELIN-1300] Implement SparkInterpreter.completion for scala 2.11#1291
Leemoonsoo wants to merge 5 commits intoapache:masterfrom
Leemoonsoo:ZEPPELIN-1300

Conversation

@Leemoonsoo
Copy link
Member

@Leemoonsoo Leemoonsoo commented Aug 6, 2016

What is this PR for?

SparkInterpreter misses code completion for scala 2.11
This PR make code completion works with spark 2.0 and scala 2.11

What type of PR is it?

Improvement

Todos

  • - Implement code completion for scala 2.11
  • - add unittest

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1300

How should this be tested?

Unittest included.
Try ctrl + . in your %spark paragraph

Screenshots (if appropriate)

image

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@Leemoonsoo
Copy link
Member Author

CI is green.
Merge to master and branch-0.6 if there're no more discussions.

@felixcheung
Copy link
Member

LGTM

@asfgit asfgit closed this in 01beb54 Aug 7, 2016
asfgit pushed a commit that referenced this pull request Aug 7, 2016
SparkInterpreter misses code completion for scala 2.11
This PR make code completion works with spark 2.0 and scala 2.11

Improvement

* [x] - Implement code completion for scala 2.11
* [x] - add unittest

https://issues.apache.org/jira/browse/ZEPPELIN-1300

Unittest included.
Try `ctrl + .` in your %spark paragraph

![image](https://cloud.githubusercontent.com/assets/1540981/17455026/703904c2-5b60-11e6-99ed-930cd47691ba.png)

* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <moon@apache.org>

Closes #1291 from Leemoonsoo/ZEPPELIN-1300 and squashes the following commits:

7edc209 [Lee moon soo] Support scala 2.11.7 as well as 2.11.8
27c572b [Lee moon soo] add log message when completer not found
909b44b [Lee moon soo] find class silently
9ecbe70 [Lee moon soo] Add create completer based on class existance
0fefc6d [Lee moon soo] Implement SparkInterpreter.completion for scala 2.11

(cherry picked from commit 01beb54)
Signed-off-by: Lee moon soo <moon@apache.org>
PhilippGrulich pushed a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
### What is this PR for?
SparkInterpreter misses code completion for scala 2.11
This PR make code completion works with spark 2.0 and scala 2.11

### What type of PR is it?
Improvement

### Todos
* [x] - Implement code completion for scala 2.11
* [x] - add unittest

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1300

### How should this be tested?
Unittest included.
Try `ctrl + .` in your %spark paragraph

### Screenshots (if appropriate)
![image](https://cloud.githubusercontent.com/assets/1540981/17455026/703904c2-5b60-11e6-99ed-930cd47691ba.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <moon@apache.org>

Closes apache#1291 from Leemoonsoo/ZEPPELIN-1300 and squashes the following commits:

7edc209 [Lee moon soo] Support scala 2.11.7 as well as 2.11.8
27c572b [Lee moon soo] add log message when completer not found
909b44b [Lee moon soo] find class silently
9ecbe70 [Lee moon soo] Add create completer based on class existance
0fefc6d [Lee moon soo] Implement SparkInterpreter.completion for scala 2.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments