[Zeppelin-1276] Fix Notebook Title Input#1273
Closed
corneadoug wants to merge 4 commits intoapache:masterfrom
Closed
[Zeppelin-1276] Fix Notebook Title Input#1273corneadoug wants to merge 4 commits intoapache:masterfrom
corneadoug wants to merge 4 commits intoapache:masterfrom
Conversation
Member
|
Tried locally and renaming notebook works now as expected. Looks great to me. Let's merge to masted, if there is no further discussion |
Contributor
Author
|
Trigger CI again |
Contributor
Author
|
Alright, CI is mainly green now. Only one Build Profile failing on Spark. |
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? The Notebook Title Input would not disappear after being edited. This is a problem made by its plugin elastic-input. We originally used ng-if instead of ng-show so it doesn't break the Page Print, however that change made the scope value to toggle unusable. So we added a trustworthy small controller on top of the component. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1276 ### How should this be tested? * Click on the Notebook title * Try to do: Enter or Esc or Click somewhere else * The Input border should not be there anymore * Do the same for the Paragraph * If you do Print Page there shouldn't any titles duplicated at the top ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <corneadoug@gmail.com> Closes apache#1273 from corneadoug/ZEPPELIN-1276 and squashes the following commits: 7d32090 [Damien CORNEAU] Remove a test that check the showEditor in NotebookCtrl 24df51f [Damien CORNEAU] Fix eslint errors d590d82 [Damien CORNEAU] apply same input changes to the paragraph b862081 [Damien CORNEAU] Fix Notebook input issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The Notebook Title Input would not disappear after being edited.
This is a problem made by its plugin elastic-input.
We originally used ng-if instead of ng-show so it doesn't break the Page Print, however that change made the scope value to toggle unusable.
So we added a trustworthy small controller on top of the component.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1276
How should this be tested?
Questions: