[ZEPPELIN-1273] Use Math.abs to determine if custom formatter should be called for y axis values

[prasadwagle]

What is this PR for?

Use Math.abs to determine if custom formatter should be called for y axis values.

What type of PR is it?

Bug Fix

Todos

• - Task

What is the Jira issue?

[ZEPPELIN-1273] https://issues.apache.org/jira/browse/ZEPPELIN-1273

How should this be tested?

Create simple table with two columns - date in one and large negative numbers like -10000000 in other. Display line chart and see that the y axis values are formatted like -10M.

Screenshots (if appropriate)

Questions:

• Does the licenses files need update?
  No
• Is there breaking changes for older versions?
  No
• Does this needs documentation?
  No

[bzz]

Looks great to me, thank you @praagarw
Merging to only to master, if there is no further discussion

A new CI error on default profile:

Running org.apache.zeppelin.interpreter.remote.RemoteInterpreterTest
04:20:49,258  INFO org.apache.zeppelin.interpreter.remote.RemoteInterpreterManagedProcess:116 - Run interpreter process [/home/travis/build/apache/zeppelin/zeppelin-interpreter/../bin/interpreter.sh, -d, fake, -p, 40254, -l, fakeRepo]
04:20:49,762  INFO org.apache.zeppelin.interpreter.remote.RemoteInterpreter:223 - Create remote interpreter org.apache.zeppelin.interpreter.remote.mock.MockInterpreterA
04:20:49,981  INFO org.apache.zeppelin.interpreter.remote.RemoteInterpreter:223 - Create remote interpreter org.apache.zeppelin.interpreter.remote.mock.MockInterpreterB
04:20:50,014 ERROR org.apache.zeppelin.interpreter.remote.RemoteInterpreterEventPoller:192 - Can't handle event RemoteInterpreterEvent(type:OUTPUT_UPDATE, data:{"data":"","noteId":"note","paragraphId":"id"})
java.lang.NullPointerException
    at org.apache.zeppelin.interpreter.remote.RemoteInterpreterEventPoller.run(RemoteInterpreterEventPoller.java:174)
...
No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.

The build has been terminated

Or do you think we should also apply this to upcoming 0.6.1 as well?

[prasadwagle]

Or do you think we should also apply this to upcoming 0.6.1 as well?
I can do that. What branch should I use for 0.6.1?

I merged with latest master this morning. Two checks in the build failed. Any ideas how to fix? I am going to restart the build in case they are due to flaky tests.

https://travis-ci.org/apache/zeppelin/jobs/149535074

Results :

Failed tests:
  ZeppelinSparkClusterTest.zRunTest:204 expected:<FINISHED> but was:<ERROR>


https://travis-ci.org/apache/zeppelin/jobs/149535075

Tests in error:
  SparkInterpreterTest.setUp:93 » NullPointer
  SparkInterpreterTest.shareSingleSparkContext:245 » NullPointer
  SparkInterpreterTest.testBasicIntp:136 » NullPointer
  SparkInterpreterTest.testCreateDataFrame:182 » NullPointer
  SparkInterpreterTest.testDisableImplicitImport:280 » NullPointer
  SparkInterpreterTest.testEnableImplicitImport:264 » NullPointer
  SparkInterpreterTest.testEndWithComment:171 » NullPointer
  SparkInterpreterTest.testListener:176 » NullPointer
  SparkInterpreterTest.testNextLineComments:160 » NullPointer
  SparkInterpreterTest.testNextLineCompanionObject:166 » NullPointer
  SparkInterpreterTest.testNextLineInvocation:155 » NullPointer
  SparkInterpreterTest.testReferencingUndefinedVal:220 » NullPointer
  SparkInterpreterTest.testSparkSql:200 » NullPointer
  SparkInterpreterTest.testZShow:193 » NullPointer
  SparkSqlInterpreterTest.setUp:61 » NullPointer
  SparkSqlInterpreterTest.setUp:61 » NullPointer
  SparkSqlInterpreterTest.setUp:61 » NullPointer

[Leemoonsoo]

@prasadwagle Thanks for the fix!
LGTM. I don't think it's blocker for 0.6.1 release, but it will be nice if we can include it in 0.6.1 release.

[Leemoonsoo]

merge into master and branch-0.6 if there're no more discussions.

[bzz]

Let's merge! :Shipit: