ZEPPELIN-1270. Remove getting SQLContext from SparkSession.wrapped() #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
\cc @Leemoonsoo Please help review, thanks |
Member
|
@zjffdu master branch now fixes the CI problem. Could you rebase master and see how CI test goes? |
Member
|
LGTM |
Contributor
Author
|
@Leemoonsoo PR rebased. |
Member
|
LGTM and merge into master and branch-0.6 |
asfgit
pushed a commit
that referenced
this pull request
Aug 7, 2016
### What is this PR for?
SparkSession.wrapped is only for spark 2.0 preview, it is not supported in spark 2.0 release. So I think we can remove that piece of code. Otherwise we will get the following error in log which might be a little confusing.
```
08:05:44,946 - Thread(pool-2-thread-3) - (Utils.java:40) - org.apache.spark.sql.SparkSession.wrapped()
java.lang.NoSuchMethodException: org.apache.spark.sql.SparkSession.wrapped()
at java.lang.Class.getMethod(Class.java:1786)
at org.apache.zeppelin.spark.Utils.invokeMethod(Utils.java:38)
at org.apache.zeppelin.spark.Utils.invokeMethod(Utils.java:33)
```
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1270
### How should this be tested?
Check the log and the above error is gone.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang <zjffdu@apache.org>
Closes #1269 from zjffdu/ZEPPELIN-1270 and squashes the following commits:
a685e66 [Jeff Zhang] ZEPPELIN-1270. Remove getting SQLContext from SparkSession.wrapped()
(cherry picked from commit b6310ad)
Signed-off-by: Lee moon soo <moon@apache.org>
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for?
SparkSession.wrapped is only for spark 2.0 preview, it is not supported in spark 2.0 release. So I think we can remove that piece of code. Otherwise we will get the following error in log which might be a little confusing.
```
08:05:44,946 - Thread(pool-2-thread-3) - (Utils.java:40) - org.apache.spark.sql.SparkSession.wrapped()
java.lang.NoSuchMethodException: org.apache.spark.sql.SparkSession.wrapped()
at java.lang.Class.getMethod(Class.java:1786)
at org.apache.zeppelin.spark.Utils.invokeMethod(Utils.java:38)
at org.apache.zeppelin.spark.Utils.invokeMethod(Utils.java:33)
```
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1270
### How should this be tested?
Check the log and the above error is gone.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang <zjffdu@apache.org>
Closes apache#1269 from zjffdu/ZEPPELIN-1270 and squashes the following commits:
a685e66 [Jeff Zhang] ZEPPELIN-1270. Remove getting SQLContext from SparkSession.wrapped()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
SparkSession.wrapped is only for spark 2.0 preview, it is not supported in spark 2.0 release. So I think we can remove that piece of code. Otherwise we will get the following error in log which might be a little confusing.
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
How should this be tested?
Check the log and the above error is gone.
Screenshots (if appropriate)
Questions: