[HOTFIX][ZEPPELIN-1240] Removed interpreter properties are restored#1239
Closed
jongyoul wants to merge 2 commits intoapache:masterfrom
Closed
[HOTFIX][ZEPPELIN-1240] Removed interpreter properties are restored#1239jongyoul wants to merge 2 commits intoapache:masterfrom
jongyoul wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
@Leemoonsoo I fixed it. Review it, please. |
Member
|
Thanks for the fix. Tested and LGTM! |
Member
Author
|
I'll trigger the CI one more, and merge it |
Member
|
Confirm that bug is gone. @jongyoul Could you rebase before merge? |
Member
Author
|
Rebased it |
Member
|
Looks great to me. CI failure: |
Member
Author
|
@Leemoonsoo @minahlee Could you please test it? |
Member
|
Tested, looks good to me. I have one question. Seems like the issue exists both in |
Member
Author
|
@minahlee Isn't it available to merge this PR into branch-0.6? |
Member
Author
Member
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? Fixing the bug that users cannot delete some interpreter settings from interpreter tab. ### What type of PR is it? [Bug Fix | Hot Fix] ### Todos * [x] - Changed `update` to `set` ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1240 ### How should this be tested? 1. Make new interpreter via interpreter tab 1. remove some properties ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <jongyoul@gmail.com> Closes apache#1239 from jongyoul/ZEPPELIN-1240 and squashes the following commits: 4cd5854 [Jongyoul Lee] Enabled to remove some properties 57cd328 [Jongyoul Lee] Changed updateProperties to setProperties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fixing the bug that users cannot delete some interpreter settings from interpreter tab.
What type of PR is it?
[Bug Fix | Hot Fix]
Todos
updatetosetWhat is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: