Skip to content

[HOTFIX][ZEPPELIN-1240] Removed interpreter properties are restored#1239

Closed
jongyoul wants to merge 2 commits intoapache:masterfrom
jongyoul:ZEPPELIN-1240
Closed

[HOTFIX][ZEPPELIN-1240] Removed interpreter properties are restored#1239
jongyoul wants to merge 2 commits intoapache:masterfrom
jongyoul:ZEPPELIN-1240

Conversation

@jongyoul
Copy link
Member

What is this PR for?

Fixing the bug that users cannot delete some interpreter settings from interpreter tab.

What type of PR is it?

[Bug Fix | Hot Fix]

Todos

  • - Changed update to set

What is the Jira issue?

How should this be tested?

  1. Make new interpreter via interpreter tab
  2. remove some properties

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@jongyoul
Copy link
Member Author

@Leemoonsoo I fixed it. Review it, please.

@Leemoonsoo
Copy link
Member

Thanks for the fix. Tested and LGTM!

@jongyoul jongyoul closed this Jul 28, 2016
@jongyoul jongyoul reopened this Jul 28, 2016
@jongyoul
Copy link
Member Author

I'll trigger the CI one more, and merge it

@minahlee
Copy link
Member

minahlee commented Aug 1, 2016

Confirm that bug is gone. @jongyoul Could you rebase before merge?

@jongyoul
Copy link
Member Author

jongyoul commented Aug 1, 2016

Rebased it

@bzz
Copy link
Member

bzz commented Aug 1, 2016

Looks great to me.

CI failure:

[INFO] Zeppelin: web Application .......................... FAILURE [02:13 min]
...
[INFO] Running 'grunt build --no-color' in /home/travis/build/apache/zeppelin/zeppelin-web
[INFO] Running "jscs:all" (jscs) task
[INFO] >> 32 files without code style errors.
[INFO] 
[INFO] Running "jscs:test" (jscs) task
[INFO] >> 6 files without code style errors.
[INFO] 
[INFO] Running "eslint:all" (eslint) task
[INFO] Warning: Cannot find module './utils' Use --force to continue.
[INFO] 
[INFO] Aborted due to warnings.
[INFO] 

@jongyoul
Copy link
Member Author

jongyoul commented Aug 2, 2016

@Leemoonsoo @minahlee Could you please test it?

@minahlee
Copy link
Member

minahlee commented Aug 3, 2016

Tested, looks good to me. I have one question. Seems like the issue exists both in master and branch-0.6 branch, will this patch be applicable to branch-0.6 or shall we create another PR targeting branch-0.6?

@jongyoul
Copy link
Member Author

jongyoul commented Aug 3, 2016

@minahlee Isn't it available to merge this PR into branch-0.6?

@jongyoul
Copy link
Member Author

jongyoul commented Aug 3, 2016

@minahlee I've made a new PR for branch-0.6 #1274

@minahlee
Copy link
Member

minahlee commented Aug 3, 2016

@jongyoul Thanks for the quick response! I will test out #1274 too

@asfgit asfgit closed this in 9efbcd1 Aug 4, 2016
PhilippGrulich pushed a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
### What is this PR for?
Fixing the bug that users cannot delete some interpreter settings from interpreter tab.

### What type of PR is it?
[Bug Fix | Hot Fix]

### Todos
* [x] - Changed `update` to `set`

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1240

### How should this be tested?
1. Make new interpreter via interpreter tab
1. remove some properties

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jongyoul Lee <jongyoul@gmail.com>

Closes apache#1239 from jongyoul/ZEPPELIN-1240 and squashes the following commits:

4cd5854 [Jongyoul Lee] Enabled to remove some properties
57cd328 [Jongyoul Lee] Changed updateProperties to setProperties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants